| Message ID | 20220503220927.960821-2-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: initial Inforce IFC6560 board support | expand |
On 2022-05-04 01:09:23, Dmitry Baryshkov wrote: > Follow the typical practice and keep DSI1/DSI1 PHY disabled by default. > They should be enabled in the board DT files. No existing boards use > them at this moment. This practice also seems to be applied to dsi0/dsi0_phy across other boards. Should this also be applied to sdm630.dtsi's dsi0/dsi0_phy nodes, and them subsequently re-enabled in sdm630-sony-xperia-nile.dtsi? > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> - Marijn > --- > arch/arm64/boot/dts/qcom/sdm660.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm660.dtsi b/arch/arm64/boot/dts/qcom/sdm660.dtsi > index eccf6fde16b4..023b0ac4118c 100644 > --- a/arch/arm64/boot/dts/qcom/sdm660.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm660.dtsi > @@ -192,6 +192,8 @@ dsi1: dsi@c996000 { > phys = <&dsi1_phy>; > phy-names = "dsi"; > > + status = "disabled"; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > @@ -225,6 +227,7 @@ dsi1_phy: dsi-phy@c996400 { > > clocks = <&mmcc MDSS_AHB_CLK>, <&rpmcc RPM_SMD_XO_CLK_SRC>; > clock-names = "iface", "ref"; > + status = "disabled"; > }; > }; > > -- > 2.35.1 >
On 04/05/2022 00:09, Dmitry Baryshkov wrote: > Follow the typical practice and keep DSI1/DSI1 PHY disabled by default. > They should be enabled in the board DT files. No existing boards use > them at this moment. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > arch/arm64/boot/dts/qcom/sdm660.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm660.dtsi b/arch/arm64/boot/dts/qcom/sdm660.dtsi > index eccf6fde16b4..023b0ac4118c 100644 > --- a/arch/arm64/boot/dts/qcom/sdm660.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm660.dtsi > @@ -192,6 +192,8 @@ dsi1: dsi@c996000 { > phys = <&dsi1_phy>; > phy-names = "dsi"; > > + status = "disabled"; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > @@ -225,6 +227,7 @@ dsi1_phy: dsi-phy@c996400 { > > clocks = <&mmcc MDSS_AHB_CLK>, <&rpmcc RPM_SMD_XO_CLK_SRC>; > clock-names = "iface", "ref"; > + status = "disabled"; > }; > }; > >
On 04/05/2022 11:11, Marijn Suijten wrote: > On 2022-05-04 01:09:23, Dmitry Baryshkov wrote: >> Follow the typical practice and keep DSI1/DSI1 PHY disabled by default. >> They should be enabled in the board DT files. No existing boards use >> them at this moment. > > This practice also seems to be applied to dsi0/dsi0_phy across other > boards. Should this also be applied to sdm630.dtsi's dsi0/dsi0_phy > nodes, and them subsequently re-enabled in sdm630-sony-xperia-nile.dtsi? I will apply corresponding changes to sdm630.dtsi. However enabling them in sdm630-sony-xperia-nile.dtsi doens't make sense at this moment, since neither of nile platforms properly describes the mdss/mdp/panel configuration. I'm looking forward to seeing the updates for these devices trees though. > >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > > - Marijn >> --- >> arch/arm64/boot/dts/qcom/sdm660.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm660.dtsi b/arch/arm64/boot/dts/qcom/sdm660.dtsi >> index eccf6fde16b4..023b0ac4118c 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm660.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm660.dtsi >> @@ -192,6 +192,8 @@ dsi1: dsi@c996000 { >> phys = <&dsi1_phy>; >> phy-names = "dsi"; >> >> + status = "disabled"; >> + >> ports { >> #address-cells = <1>; >> #size-cells = <0>; >> @@ -225,6 +227,7 @@ dsi1_phy: dsi-phy@c996400 { >> >> clocks = <&mmcc MDSS_AHB_CLK>, <&rpmcc RPM_SMD_XO_CLK_SRC>; >> clock-names = "iface", "ref"; >> + status = "disabled"; >> }; >> }; >> >> -- >> 2.35.1 >>
On 2022-05-13 00:58:32, Dmitry Baryshkov wrote: > On 04/05/2022 11:11, Marijn Suijten wrote: > > On 2022-05-04 01:09:23, Dmitry Baryshkov wrote: > >> Follow the typical practice and keep DSI1/DSI1 PHY disabled by default. > >> They should be enabled in the board DT files. No existing boards use > >> them at this moment. > > > > This practice also seems to be applied to dsi0/dsi0_phy across other > > boards. Should this also be applied to sdm630.dtsi's dsi0/dsi0_phy > > nodes, and them subsequently re-enabled in sdm630-sony-xperia-nile.dtsi? > > I will apply corresponding changes to sdm630.dtsi. However enabling them > in sdm630-sony-xperia-nile.dtsi doens't make sense at this moment, since > neither of nile platforms properly describes the mdss/mdp/panel > configuration. I'm looking forward to seeing the updates for these > devices trees though. Thanks, I'll rebase your patches into my public Nile branch and fix this up on my end, as to not forget this when hopefully sending more enablement for this platform at "some point...". - Marijn > > > >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > > > > - Marijn > >> --- > >> arch/arm64/boot/dts/qcom/sdm660.dtsi | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/sdm660.dtsi b/arch/arm64/boot/dts/qcom/sdm660.dtsi > >> index eccf6fde16b4..023b0ac4118c 100644 > >> --- a/arch/arm64/boot/dts/qcom/sdm660.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/sdm660.dtsi > >> @@ -192,6 +192,8 @@ dsi1: dsi@c996000 { > >> phys = <&dsi1_phy>; > >> phy-names = "dsi"; > >> > >> + status = "disabled"; > >> + > >> ports { > >> #address-cells = <1>; > >> #size-cells = <0>; > >> @@ -225,6 +227,7 @@ dsi1_phy: dsi-phy@c996400 { > >> > >> clocks = <&mmcc MDSS_AHB_CLK>, <&rpmcc RPM_SMD_XO_CLK_SRC>; > >> clock-names = "iface", "ref"; > >> + status = "disabled"; > >> }; > >> }; > >> > >> -- > >> 2.35.1 > >> > > > -- > With best wishes > Dmitry
diff --git a/arch/arm64/boot/dts/qcom/sdm660.dtsi b/arch/arm64/boot/dts/qcom/sdm660.dtsi index eccf6fde16b4..023b0ac4118c 100644 --- a/arch/arm64/boot/dts/qcom/sdm660.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm660.dtsi @@ -192,6 +192,8 @@ dsi1: dsi@c996000 { phys = <&dsi1_phy>; phy-names = "dsi"; + status = "disabled"; + ports { #address-cells = <1>; #size-cells = <0>; @@ -225,6 +227,7 @@ dsi1_phy: dsi-phy@c996400 { clocks = <&mmcc MDSS_AHB_CLK>, <&rpmcc RPM_SMD_XO_CLK_SRC>; clock-names = "iface", "ref"; + status = "disabled"; }; };
Follow the typical practice and keep DSI1/DSI1 PHY disabled by default. They should be enabled in the board DT files. No existing boards use them at this moment. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/sdm660.dtsi | 3 +++ 1 file changed, 3 insertions(+)