| Message ID | 20220513175849.4335-1-quic_ppareek@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3] soc: qcom: Fix the id of SA8540P SoC | expand |
On 5/13/2022 11:28 PM, Parikshit Pareek wrote: > Change the id of SA8540P to its correct value, i.e., 461. > > Fixes: 76ee15ae1b13 ("soc: qcom: socinfo: Add some more PMICs and SoCs") > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > Reviewed-by: Eric Chanudet <echanude@redhat.com> > Tested-by: Eric Chanudet <echanude@redhat.com> > --- > drivers/soc/qcom/socinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > index cee579a267a6..c37d7724c7d0 100644 > --- a/drivers/soc/qcom/socinfo.c > +++ b/drivers/soc/qcom/socinfo.c > @@ -328,7 +328,7 @@ static const struct soc_id soc_id[] = { > { 455, "QRB5165" }, > { 457, "SM8450" }, > { 459, "SM7225" }, > - { 460, "SA8540P" }, > + { 461, "SA8540P" }, > { 480, "SM8450" }, > { 482, "SM8450" }, > { 487, "SC7280" }, Reviewed-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> Thanks, Sai
On Fri, May 13, 2022 at 11:28:49PM +0530, Parikshit Pareek wrote: > Change the id of SA8540P to its correct value, i.e., 461. > > Fixes: 76ee15ae1b13 ("soc: qcom: socinfo: Add some more PMICs and SoCs") > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > Reviewed-by: Eric Chanudet <echanude@redhat.com> > Tested-by: Eric Chanudet <echanude@redhat.com> Reviewed-by: Brian Masney <bmasney@redhat.com>
On Fri 13 May 12:58 CDT 2022, Parikshit Pareek wrote: > Change the id of SA8540P to its correct value, i.e., 461. > > Fixes: 76ee15ae1b13 ("soc: qcom: socinfo: Add some more PMICs and SoCs") > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > Reviewed-by: Eric Chanudet <echanude@redhat.com> > Tested-by: Eric Chanudet <echanude@redhat.com> > --- > drivers/soc/qcom/socinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > index cee579a267a6..c37d7724c7d0 100644 > --- a/drivers/soc/qcom/socinfo.c > +++ b/drivers/soc/qcom/socinfo.c > @@ -328,7 +328,7 @@ static const struct soc_id soc_id[] = { > { 455, "QRB5165" }, > { 457, "SM8450" }, > { 459, "SM7225" }, > - { 460, "SA8540P" }, > + { 461, "SA8540P" }, I don't have any objections to this addition. But I have a board with soc_id of 460, so can you please correct the entry for that instead of removing it? Thanks, Bjorn > { 480, "SM8450" }, > { 482, "SM8450" }, > { 487, "SC7280" }, > -- > 2.17.1 >
On Sat, Jun 25, 2022 at 10:15:25PM -0500, Bjorn Andersson wrote: > On Fri 13 May 12:58 CDT 2022, Parikshit Pareek wrote: > > > Change the id of SA8540P to its correct value, i.e., 461. > > > > Fixes: 76ee15ae1b13 ("soc: qcom: socinfo: Add some more PMICs and SoCs") > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > > Reviewed-by: Eric Chanudet <echanude@redhat.com> > > Tested-by: Eric Chanudet <echanude@redhat.com> > > --- > > drivers/soc/qcom/socinfo.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > > index cee579a267a6..c37d7724c7d0 100644 > > --- a/drivers/soc/qcom/socinfo.c > > +++ b/drivers/soc/qcom/socinfo.c > > @@ -328,7 +328,7 @@ static const struct soc_id soc_id[] = { > > { 455, "QRB5165" }, > > { 457, "SM8450" }, > > { 459, "SM7225" }, > > - { 460, "SA8540P" }, > > + { 461, "SA8540P" }, > > I don't have any objections to this addition. > > But I have a board with soc_id of 460, so can you please correct the > entry for that instead of removing it? Sure, the entry 460 should be introduced for "SA8295P". Thanks for intimation, and sorry for late response. > > Thanks, > Bjorn > > > { 480, "SM8450" }, > > { 482, "SM8450" }, > > { 487, "SC7280" }, > > -- > > 2.17.1 > > Regards, Parikshit Pareek
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c index cee579a267a6..c37d7724c7d0 100644 --- a/drivers/soc/qcom/socinfo.c +++ b/drivers/soc/qcom/socinfo.c @@ -328,7 +328,7 @@ static const struct soc_id soc_id[] = { { 455, "QRB5165" }, { 457, "SM8450" }, { 459, "SM7225" }, - { 460, "SA8540P" }, + { 461, "SA8540P" }, { 480, "SM8450" }, { 482, "SM8450" }, { 487, "SC7280" },
Change the id of SA8540P to its correct value, i.e., 461. Fixes: 76ee15ae1b13 ("soc: qcom: socinfo: Add some more PMICs and SoCs") Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> Reviewed-by: Eric Chanudet <echanude@redhat.com> Tested-by: Eric Chanudet <echanude@redhat.com> --- drivers/soc/qcom/socinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)