| Message ID | 20220513234518.3068480-5-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: initial Inforce IFC6560 board support | expand |
On 2022-05-14 02:45:14, Dmitry Baryshkov wrote: > According to the downstram DT file, the qusb2phy ref clock should be > GCC_RX0_USB2_CLKREF_CLK, not GCC_RX1_USB2_CLKREF_CLK. > > Fixes: c65a4ed2ea8b ("arm64: dts: qcom: sdm630: Add USB configuration") > Cc: Konrad Dybcio <konrad.dybcio@somainline.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> One nit below. > --- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi > index e8bb170e8b2f..cca56f2fad96 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > @@ -1262,7 +1262,7 @@ qusb2phy: phy@c012000 { > #phy-cells = <0>; > > clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>, > - <&gcc GCC_RX1_USB2_CLKREF_CLK>; > + <&gcc GCC_RX0_USB2_CLKREF_CLK>; While at it, should this patch fix the indentation or shall I or you do a one-off patch correcting the entire file (either before or after your series)? - Marijn > clock-names = "cfg_ahb", "ref"; > > resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>; > -- > 2.35.1 >
On 14/05/2022 12:56, Marijn Suijten wrote: > On 2022-05-14 02:45:14, Dmitry Baryshkov wrote: >> According to the downstram DT file, the qusb2phy ref clock should be >> GCC_RX0_USB2_CLKREF_CLK, not GCC_RX1_USB2_CLKREF_CLK. >> >> Fixes: c65a4ed2ea8b ("arm64: dts: qcom: sdm630: Add USB configuration") >> Cc: Konrad Dybcio <konrad.dybcio@somainline.org> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > > One nit below. > >> --- >> arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> index e8bb170e8b2f..cca56f2fad96 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> @@ -1262,7 +1262,7 @@ qusb2phy: phy@c012000 { >> #phy-cells = <0>; >> >> clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>, >> - <&gcc GCC_RX1_USB2_CLKREF_CLK>; >> + <&gcc GCC_RX0_USB2_CLKREF_CLK>; > > While at it, should this patch fix the indentation or shall I or you do > a one-off patch correcting the entire file (either before or after your > series)? I'd prefer to land these two series, after that we can indent the rest. > > - Marijn > >> clock-names = "cfg_ahb", "ref"; >> >> resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>; >> -- >> 2.35.1 >>
diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index e8bb170e8b2f..cca56f2fad96 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -1262,7 +1262,7 @@ qusb2phy: phy@c012000 { #phy-cells = <0>; clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>, - <&gcc GCC_RX1_USB2_CLKREF_CLK>; + <&gcc GCC_RX0_USB2_CLKREF_CLK>; clock-names = "cfg_ahb", "ref"; resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
According to the downstram DT file, the qusb2phy ref clock should be GCC_RX0_USB2_CLKREF_CLK, not GCC_RX1_USB2_CLKREF_CLK. Fixes: c65a4ed2ea8b ("arm64: dts: qcom: sdm630: Add USB configuration") Cc: Konrad Dybcio <konrad.dybcio@somainline.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)