| Message ID | 20220521152049.1490220-2-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: initial Inforce IFC6560 board support | expand |
On 2022-05-21 18:20:39, Dmitry Baryshkov wrote: > Follow the typical practice and keep DSI0/DSI0 PHY disabled by default. > They should be enabled in the board DT files. No existing boards use > them at this moment. > > Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> I also added my: Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> To v5, to confirm the Suggested-by. > --- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi > index 240293592ef9..8697d40e9b74 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > @@ -1559,6 +1559,8 @@ dsi0: dsi@c994000 { > phys = <&dsi0_phy>; > phy-names = "dsi"; > > + status = "disabled"; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > @@ -1592,6 +1594,7 @@ dsi0_phy: dsi-phy@c994400 { > > clocks = <&mmcc MDSS_AHB_CLK>, <&xo_board>; > clock-names = "iface", "ref"; > + status = "disabled"; > }; > }; > > -- > 2.35.1 >
On 21/05/2022 18:06, Marijn Suijten wrote: > On 2022-05-21 18:20:39, Dmitry Baryshkov wrote: >> Follow the typical practice and keep DSI0/DSI0 PHY disabled by default. >> They should be enabled in the board DT files. No existing boards use >> them at this moment. >> >> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > I also added my: > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > > To v5, to confirm the Suggested-by. Reviewed-by tag is not used to confirm other tags like reported or suggested. It means you performed the review and you state what is described in "Reviewer's statement of oversight". Don't add the tag for reasons other than described in that statement of oversight. Best regards, Krzysztof
On 2022-05-21 18:49:36, Krzysztof Kozlowski wrote: > On 21/05/2022 18:06, Marijn Suijten wrote: > > On 2022-05-21 18:20:39, Dmitry Baryshkov wrote: > >> Follow the typical practice and keep DSI0/DSI0 PHY disabled by default. > >> They should be enabled in the board DT files. No existing boards use > >> them at this moment. > >> > >> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> > >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > I also added my: > > > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > > > > To v5, to confirm the Suggested-by. > > Reviewed-by tag is not used to confirm other tags like reported or > suggested. It means you performed the review and you state what is > described in "Reviewer's statement of oversight". That is obviously implied, otherwise I wouldn't have sent a Reviewed-by in the first place. However, I don't think Suggested-by quite carries the load of a Reviewed-by (at all...), so I don't understand why my Reviewed-by's have strangely been picked up for every patch except those where my name is already listed as Suggested-by or Reported-by, those are completely separate things. - Marijn
On 21/05/2022 19:06, Marijn Suijten wrote: > On 2022-05-21 18:20:39, Dmitry Baryshkov wrote: >> Follow the typical practice and keep DSI0/DSI0 PHY disabled by default. >> They should be enabled in the board DT files. No existing boards use >> them at this moment. >> >> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > I also added my: > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> Please excuse me. I didn't pick up your R-b tags by mistake. > > To v5, to confirm the Suggested-by. > >> --- >> arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> index 240293592ef9..8697d40e9b74 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> @@ -1559,6 +1559,8 @@ dsi0: dsi@c994000 { >> phys = <&dsi0_phy>; >> phy-names = "dsi"; >> >> + status = "disabled"; >> + >> ports { >> #address-cells = <1>; >> #size-cells = <0>; >> @@ -1592,6 +1594,7 @@ dsi0_phy: dsi-phy@c994400 { >> >> clocks = <&mmcc MDSS_AHB_CLK>, <&xo_board>; >> clock-names = "iface", "ref"; >> + status = "disabled"; >> }; >> }; >> >> -- >> 2.35.1 >>
On 2022-05-21 23:13:49, Dmitry Baryshkov wrote: > On 21/05/2022 19:06, Marijn Suijten wrote: > > On 2022-05-21 18:20:39, Dmitry Baryshkov wrote: > >> Follow the typical practice and keep DSI0/DSI0 PHY disabled by default. > >> They should be enabled in the board DT files. No existing boards use > >> them at this moment. > >> > >> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> > >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > I also added my: > > > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > > Please excuse me. I didn't pick up your R-b tags by mistake. No worries, it just seemed coincidental to have them picked up on every patch except the ones which already had a Suggested/Reported-by tag, thanks for picking them up now! - Marijn
diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index 240293592ef9..8697d40e9b74 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -1559,6 +1559,8 @@ dsi0: dsi@c994000 { phys = <&dsi0_phy>; phy-names = "dsi"; + status = "disabled"; + ports { #address-cells = <1>; #size-cells = <0>; @@ -1592,6 +1594,7 @@ dsi0_phy: dsi-phy@c994400 { clocks = <&mmcc MDSS_AHB_CLK>, <&xo_board>; clock-names = "iface", "ref"; + status = "disabled"; }; };