diff mbox series

[12/12] arm64: dts: qcom: msm8998-mtp: correct board compatible

Message ID 20220521164550.91115-12-krzysztof.kozlowski@linaro.org (mailing list archive)
State New
Headers show
Series [01/12] dt-bindings: vendor-prefixes: add Shift GmbH | expand

Commit Message

Krzysztof Kozlowski May 21, 2022, 4:45 p.m. UTC
Add qcom,msm8998 SoC fallback to the board compatible.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998-mtp.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio May 22, 2022, 9:11 a.m. UTC | #1
On 21.05.2022 18:45, Krzysztof Kozlowski wrote:
> Add qcom,msm8998 SoC fallback to the board compatible.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/msm8998-mtp.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dts b/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
> index 66540d2ca13b..db240a3207dc 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
> @@ -7,7 +7,7 @@
>  
>  / {
>  	model = "Qualcomm Technologies, Inc. MSM8998 v1 MTP";
A bit off-topic, but should this board still be considered supported? If it really is msm8998v1, it should not work in the current state of mainline, as there are many differences between the pre-production v1 and the final v2.1, even as deep as in the clock tree.

Konrad
> -	compatible = "qcom,msm8998-mtp";
> +	compatible = "qcom,msm8998-mtp", "qcom,msm8998";
>  
>  	qcom,board-id = <8 0>;
>  };
>
Krzysztof Kozlowski May 22, 2022, 9:20 a.m. UTC | #2
On 22/05/2022 11:11, Konrad Dybcio wrote:
> 
> 
> On 21.05.2022 18:45, Krzysztof Kozlowski wrote:
>> Add qcom,msm8998 SoC fallback to the board compatible.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/msm8998-mtp.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dts b/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
>> index 66540d2ca13b..db240a3207dc 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
>> @@ -7,7 +7,7 @@
>>  
>>  / {
>>  	model = "Qualcomm Technologies, Inc. MSM8998 v1 MTP";
> A bit off-topic, but should this board still be considered supported? If it really is msm8998v1, it should not work in the current state of mainline, as there are many differences between the pre-production v1 and the final v2.1, even as deep as in the clock tree.

Unless you are sure there are no users or it is not working, there is
not much benefit to remove such board. Specially that it's DTSI is
re-used by one more - fxtec-pro1.


Best regards,
Krzysztof
Krzysztof Kozlowski June 22, 2022, 8:35 a.m. UTC | #3
On Sat, 21 May 2022 18:45:50 +0200, Krzysztof Kozlowski wrote:
> Add qcom,msm8998 SoC fallback to the board compatible.
> 
> 

Applied, thanks!

[12/12] arm64: dts: qcom: msm8998-mtp: correct board compatible
        https://git.kernel.org/krzk/linux/c/4fb4a39fdbc8bd0aa35de0970d26cbc6c5abf946

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dts b/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
index 66540d2ca13b..db240a3207dc 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
@@ -7,7 +7,7 @@ 
 
 / {
 	model = "Qualcomm Technologies, Inc. MSM8998 v1 MTP";
-	compatible = "qcom,msm8998-mtp";
+	compatible = "qcom,msm8998-mtp", "qcom,msm8998";
 
 	qcom,board-id = <8 0>;
 };