diff mbox series

[net,1/2] net: ipa: fix page free in ipa_endpoint_trans_release()

Message ID 20220522005959.1175181-2-elder@linaro.org (mailing list archive)
State Superseded
Headers show
Series net: ipa: fix page free in two spots | expand

Commit Message

Alex Elder May 22, 2022, 12:59 a.m. UTC
Currently the (possibly compound) page used for receive buffers are
freed using __free_pages().  But according to this comment above the
definition of that function, that's wrong:
    If you want to use the page's reference count to decide when
    to free the allocation, you should allocate a compound page,
    and use put_page() instead of __free_pages().

Convert the call to __free_pages() in ipa_endpoint_trans_release()
to use put_page() instead.

Fixes: ed23f02680caa ("net: ipa: define per-endpoint receive buffer size")
Signed-off-by: Alex Elder <elder@linaro.org>
 drivers/net/ipa/ipa_endpoint.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff mbox series


diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
index 0f489723689c5..675b7135644b8 100644
--- a/drivers/net/ipa/ipa_endpoint.c
+++ b/drivers/net/ipa/ipa_endpoint.c
@@ -1385,11 +1385,8 @@  void ipa_endpoint_trans_release(struct ipa_endpoint *endpoint,
 	} else {
 		struct page *page = trans->data;
-		if (page) {
-			u32 buffer_size = endpoint->config.rx.buffer_size;
-			__free_pages(page, get_order(buffer_size));
-		}
+		if (page)
+			put_page(page);