diff mbox series

[7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode

Message ID 20220630120845.3356144-8-bryan.odonoghue@linaro.org (mailing list archive)
State Not Applicable
Headers show
Series msm8916/msm8939 DSI controller and DSI PHY bindings fixes | expand

Commit Message

Bryan O'Donoghue June 30, 2022, 12:08 p.m. UTC
Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
When converting from .txt to .yaml we missed this one.

Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 .../devicetree/bindings/display/msm/dsi-phy-28nm.yaml          | 3 +++
 1 file changed, 3 insertions(+)

Comments

Dmitry Baryshkov June 30, 2022, 5:18 p.m. UTC | #1
On 30 June 2022 15:08:45 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
>When converting from .txt to .yaml we missed this one.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


>---
> .../devicetree/bindings/display/msm/dsi-phy-28nm.yaml          | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>index 9ecd513d93661..3551e166db966 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>@@ -40,6 +40,9 @@ properties:
>       - description: dsi phy register set
>       - description: dsi phy regulator register set
> 
>+  qcom,dsi-phy-regulator-ldo-mode:
>+    description: Boolean value indicating if the LDO mode PHY regulator is wanted.
>+
>   reg-names:
>     items:
>       - const: dsi_pll
Krzysztof Kozlowski June 30, 2022, 7:07 p.m. UTC | #2
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed this one.
> 
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../devicetree/bindings/display/msm/dsi-phy-28nm.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> index 9ecd513d93661..3551e166db966 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> @@ -40,6 +40,9 @@ properties:
>        - description: dsi phy register set
>        - description: dsi phy regulator register set
>  
> +  qcom,dsi-phy-regulator-ldo-mode:
> +    description: Boolean value indicating if the LDO mode PHY regulator is wanted.

You need type:boolean. Didn't dt_bindings_check complain?

Then description can be shorter "Whether the LDO mode PHY regulator is
wanted."

> +
>    reg-names:
>      items:
>        - const: dsi_pll


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
index 9ecd513d93661..3551e166db966 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
@@ -40,6 +40,9 @@  properties:
       - description: dsi phy register set
       - description: dsi phy regulator register set
 
+  qcom,dsi-phy-regulator-ldo-mode:
+    description: Boolean value indicating if the LDO mode PHY regulator is wanted.
+
   reg-names:
     items:
       - const: dsi_pll