| Message ID | 20220711094320.368062-2-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm/dsi: stop using drm_panel directly | expand |
On 7/11/2022 2:43 AM, Dmitry Baryshkov wrote: > The commit 0f40ba48de3b ("drm/msm/dsi: Pass DSC params to drm_panel") > added a pointer to the DSC data to the struct drm_panel. However DSC > support is not limited to the DSI panels. MIPI DSI bridges can also > consume DSC command streams. Thus add struct drm_dsc_config pointer to > the struct mipi_dsi_device. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Agreed, DSC params are not limited to a drm_panel. From that standpoint, this change seems logical to me, hence Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > include/drm/drm_mipi_dsi.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 91a164bdd8f3..bb20bc27ce87 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -179,6 +179,7 @@ struct mipi_dsi_device_info { > * @lp_rate: maximum lane frequency for low power mode in hertz, this should > * be set to the real limits of the hardware, zero is only accepted for > * legacy drivers > + * @dsc: panel/bridge DSC pps payload to be sent > */ > struct mipi_dsi_device { > struct mipi_dsi_host *host; > @@ -191,6 +192,7 @@ struct mipi_dsi_device { > unsigned long mode_flags; > unsigned long hs_rate; > unsigned long lp_rate; > + struct drm_dsc_config *dsc; > }; > > #define MIPI_DSI_MODULE_PREFIX "mipi-dsi:"
diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 91a164bdd8f3..bb20bc27ce87 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -179,6 +179,7 @@ struct mipi_dsi_device_info { * @lp_rate: maximum lane frequency for low power mode in hertz, this should * be set to the real limits of the hardware, zero is only accepted for * legacy drivers + * @dsc: panel/bridge DSC pps payload to be sent */ struct mipi_dsi_device { struct mipi_dsi_host *host; @@ -191,6 +192,7 @@ struct mipi_dsi_device { unsigned long mode_flags; unsigned long hs_rate; unsigned long lp_rate; + struct drm_dsc_config *dsc; }; #define MIPI_DSI_MODULE_PREFIX "mipi-dsi:"
The commit 0f40ba48de3b ("drm/msm/dsi: Pass DSC params to drm_panel") added a pointer to the DSC data to the struct drm_panel. However DSC support is not limited to the DSI panels. MIPI DSI bridges can also consume DSC command streams. Thus add struct drm_dsc_config pointer to the struct mipi_dsi_device. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- include/drm/drm_mipi_dsi.h | 2 ++ 1 file changed, 2 insertions(+)