| Message ID | 20220711174133.28882-1-quic_ppareek@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1189a9cf144a745e4b98ff4f6cf5f79ab0b56cfb |
| Headers | show |
| Series | arm64: dts: qcom: fix the smmu interrupt values | expand |
On Mon, Jul 11, 2022 at 11:11:33PM +0530, Parikshit Pareek wrote: > There has been wrong values introduced for context interrupt for > smu node apps_smmu. Fix those ones with due correction. > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 7945cbb57bb4..1276a833251e 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1580,7 +1580,6 @@ > <GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>, > @@ -1591,6 +1590,7 @@ > <GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>, > -- > 2.17.1 > I think you'll wanna use the subject prefix "arm64: dts: qcom: sc8280xp:" here, and in my opinion removing the 424 irq should be referred to as removing a duplicate (since its still listed), and then another patch adding the missing one. Super pedantic but I'd do it like: 1: arm64: dts: qcom: sc8280xp: remove duplicate apps_smmu irq 2: arm64: dts: qcom: sc8280xp: add missing apps_smmu irq That being said that's just my opinionated drive by review. For what it is worth I checked the downstream source I have access to and the diff here makes sense to me, so with the commit message fixed up a bit (at least including the proper prefix): Reviewed-by: Andrew Halaney <ahalaney@redhat.com> Thanks, Andrew
On Mon, 11 Jul 2022 23:11:33 +0530, Parikshit Pareek wrote: > There has been wrong values introduced for context interrupt for > smu node apps_smmu. Fix those ones with due correction. > > Applied, thanks! [1/1] arm64: dts: qcom: fix the smmu interrupt values commit: 1189a9cf144a745e4b98ff4f6cf5f79ab0b56cfb Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 7945cbb57bb4..1276a833251e 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1580,7 +1580,6 @@ <GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>, @@ -1591,6 +1590,7 @@ <GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
There has been wrong values introduced for context interrupt for smu node apps_smmu. Fix those ones with due correction. Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)