| Message ID | 20220712080156.1364-1-quic_ppareek@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp: add missing apps_smmu irq | expand |
On Tue, Jul 12, 2022 at 01:31:56PM +0530, Parikshit Pareek wrote: > Add missing irq number 696, and correct the interrupt-mapping of context banks. > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 7945cbb57bb4..1197d60c2827 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1591,6 +1591,7 @@ > <GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>, > -- > 2.17.1 > Looks good to me, thanks! Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
On Tue, 12 Jul 2022 at 11:02, Parikshit Pareek <quic_ppareek@quicinc.com> wrote: > > Add missing irq number 696, and correct the interrupt-mapping of context banks. If these two patches touch the same device (and the same interrupts property), it might be better to merge them into the single patch. > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 7945cbb57bb4..1197d60c2827 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1591,6 +1591,7 @@ > <GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>, > -- > 2.17.1 >
On Tue, Jul 12, 2022 at 03:10:16PM +0300, Dmitry Baryshkov wrote: > On Tue, 12 Jul 2022 at 11:02, Parikshit Pareek <quic_ppareek@quicinc.com> wrote: > > > > Add missing irq number 696, and correct the interrupt-mapping of context banks. > > If these two patches touch the same device (and the same interrupts > property), it might be better to merge them into the single patch. > Heh, I mislead Parikshit into splitting them... sorry! > > > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > > --- > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > index 7945cbb57bb4..1197d60c2827 100644 > > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > @@ -1591,6 +1591,7 @@ > > <GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>, > > -- > > 2.17.1 > > > > > -- > With best wishes > Dmitry >
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 7945cbb57bb4..1197d60c2827 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1591,6 +1591,7 @@ <GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
Add missing irq number 696, and correct the interrupt-mapping of context banks. Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + 1 file changed, 1 insertion(+)