diff mbox series

[6/6] clk: qcom: gcc-msm8939: Add missing USB HS system clock frequencies

Message ID 20220712125922.3461675-7-bryan.odonoghue@linaro.org (mailing list archive)
State Accepted
Headers show
Series clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver | expand

Commit Message

Bryan O'Donoghue July 12, 2022, 12:59 p.m. UTC
The shipped qcom driver defines:
static struct clk_freq_tbl ftbl_gcc_usb_hs_system_clk[] = {
        F(  57140000,      gpll0_out_main,  14,    0,    0),
        F(  80000000,      gpll0_out_main,  10,   0,    0),
        F( 100000000,      gpll0_out_main,   8,   0,    0),
        F_END
};
In the upstream code we omit 57.14 MHz and 100 MHz.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/clk/qcom/gcc-msm8939.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Konrad Dybcio July 12, 2022, 4:18 p.m. UTC | #1
On 12.07.2022 14:59, Bryan O'Donoghue wrote:
> The shipped qcom driver defines:
> static struct clk_freq_tbl ftbl_gcc_usb_hs_system_clk[] = {
>         F(  57140000,      gpll0_out_main,  14,    0,    0),
>         F(  80000000,      gpll0_out_main,  10,   0,    0),
>         F( 100000000,      gpll0_out_main,   8,   0,    0),
>         F_END
> };
> In the upstream code we omit 57.14 MHz and 100 MHz.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Konrad
>  drivers/clk/qcom/gcc-msm8939.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 7f71491d52c4b..754d5573b1df5 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -1468,7 +1468,9 @@ static struct clk_rcg2 bimc_gpu_clk_src = {
>  };
>  
>  static const struct freq_tbl ftbl_gcc_usb_hs_system_clk[] = {
> +	F(57140000, P_GPLL0, 14, 0, 0),
>  	F(80000000, P_GPLL0, 10, 0, 0),
> +	F(100000000, P_GPLL0, 8, 0, 0),
>  	{ }
>  };
>
Bryan O'Donoghue July 12, 2022, 4:19 p.m. UTC | #2
On 12/07/2022 17:18, Konrad Dybcio wrote:
> 
> 
> On 12.07.2022 14:59, Bryan O'Donoghue wrote:
>> The shipped qcom driver defines:
>> static struct clk_freq_tbl ftbl_gcc_usb_hs_system_clk[] = {
>>          F(  57140000,      gpll0_out_main,  14,    0,    0),
>>          F(  80000000,      gpll0_out_main,  10,   0,    0),
>>          F( 100000000,      gpll0_out_main,   8,   0,    0),
>>          F_END
>> };
>> In the upstream code we omit 57.14 MHz and 100 MHz.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> 
> Konrad

Thx for the review, appreciated.

---
bod
diff mbox series

Patch

diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
index 7f71491d52c4b..754d5573b1df5 100644
--- a/drivers/clk/qcom/gcc-msm8939.c
+++ b/drivers/clk/qcom/gcc-msm8939.c
@@ -1468,7 +1468,9 @@  static struct clk_rcg2 bimc_gpu_clk_src = {
 };
 
 static const struct freq_tbl ftbl_gcc_usb_hs_system_clk[] = {
+	F(57140000, P_GPLL0, 14, 0, 0),
 	F(80000000, P_GPLL0, 10, 0, 0),
+	F(100000000, P_GPLL0, 8, 0, 0),
 	{ }
 };