| Message ID | 20220714072253.63052-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err() | expand |
On 14/07/2022 09:22, Yang Li wrote: > Eliminate the follow coccicheck warning: > ./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> This was reported by coccinelle, not a robot, so the tag is not appropriate. This is an open source work and public collaboration. The "Reported-by" usually means that the issue was reported to us, in some way, usually in public. Can we see the report? Otherwise adding non-public, non-verifiable reports is useless and clutters our report-credit-system. Best regards, Krzysztof
diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c index bea3ea1de7a4..7f8aca533cd3 100644 --- a/drivers/soc/qcom/icc-bwmon.c +++ b/drivers/soc/qcom/icc-bwmon.c @@ -345,10 +345,8 @@ static int bwmon_probe(struct platform_device *pdev) } bwmon->irq = platform_get_irq(pdev, 0); - if (bwmon->irq < 0) { - dev_err(dev, "failed to acquire bwmon IRQ\n"); + if (bwmon->irq < 0) return bwmon->irq; - } ret = devm_pm_opp_of_add_table(dev); if (ret)
Eliminate the follow coccicheck warning: ./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/soc/qcom/icc-bwmon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)