diff mbox series

[RESEND,1/4] dt-bindings: qcom: Document bindings for new msm8916-samsung-e2015 devices

Message ID 20220715102055.3844-1-linmengbo0689@protonmail.com (mailing list archive)
State Superseded
Headers show
Series [RESEND,1/4] dt-bindings: qcom: Document bindings for new msm8916-samsung-e2015 devices | expand

Commit Message

Lin, Meng-Bo July 15, 2022, 10:21 a.m. UTC
Document the new samsung,e5/e7/grandmax device tree bindings used in their
device trees.

Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++
 1 file changed, 3 insertions(+)

--
2.30.2

Comments

Lin, Meng-Bo July 17, 2022, 11:01 a.m. UTC | #1
On Friday, July 15th, 2022 at 10:00 AM, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> I just received one patch, no cover letter, no threading (I asked for),
> no changelog against v1, no binding updates (I asked for).

I have had them all in a thread in latest resend. The v2 was accident.
There is nothing changed except dt-binding added in new commit.

> Sorry, the process does not work like that.
>
> You receive comments, so either you apply them or you keep discussing
> with reviewer.

Sorry for the confusing and inconvenience. Please have another look at my patch.
Thank you for your patience.

Best regards,
Lin
Krzysztof Kozlowski July 18, 2022, 1:09 p.m. UTC | #2
On 15/07/2022 12:21, Lin, Meng-Bo wrote:
> Document the new samsung,e5/e7/grandmax device tree bindings used in their
> device trees.
> 
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>

Sorry, it's confusing. There was a v1. I asked for changes Then there
was a v2.

...and now is resend of v1, so you decided not to implement changes.

Send v3, with all changes applied or keep discussion going.

Best regards,
Krzysztof
Krzysztof Kozlowski July 18, 2022, 1:09 p.m. UTC | #3
On 15/07/2022 12:21, Lin, Meng-Bo wrote:
> Document the new samsung,e5/e7/grandmax device tree bindings used in their
> device trees.
> 
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++

If this is resend of v1, why I cannot find this patch in v1?


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 5c06d1bfc046..b004f42bc277 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -164,6 +164,9 @@  properties:
               - longcheer,l8150
               - samsung,a3u-eur
               - samsung,a5u-eur
+              - samsung,e5
+              - samsung,e7
+              - samsung,grandmax
           - const: qcom,msm8916

       - items: