diff mbox series

[2/6] dt-bindings: firmware: scm: Add compatible for SM6375

Message ID 20220716193257.456023-2-konrad.dybcio@somainline.org (mailing list archive)
State Changes Requested
Headers show
Series None | expand

Commit Message

Konrad Dybcio July 16, 2022, 7:32 p.m. UTC
Add a SCM compatible for SM6375.

Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
 Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski July 18, 2022, 2:29 p.m. UTC | #1
On 16/07/2022 21:32, Konrad Dybcio wrote:
> Add a SCM compatible for SM6375.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
>  Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> index b3f702cbed87..de7bb8b8d85e 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> @@ -35,6 +35,7 @@ Required properties:
>   * "qcom,scm-sm8250"
>   * "qcom,scm-sm8350"
>   * "qcom,scm-sm8450"
> + * "qcom,sm6375-scm"

Uh, I think we wanted to keep it consistent with existing ones, didn't we?


Best regards,
Krzysztof
Konrad Dybcio July 18, 2022, 2:34 p.m. UTC | #2
On 18.07.2022 16:29, Krzysztof Kozlowski wrote:
> On 16/07/2022 21:32, Konrad Dybcio wrote:
>> Add a SCM compatible for SM6375.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>> ---
>>  Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
>> index b3f702cbed87..de7bb8b8d85e 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
>> @@ -35,6 +35,7 @@ Required properties:
>>   * "qcom,scm-sm8250"
>>   * "qcom,scm-sm8350"
>>   * "qcom,scm-sm8450"
>> + * "qcom,sm6375-scm"
> 
> Uh, I think we wanted to keep it consistent with existing ones, didn't we?
> 
I still haven't sent DT yet (need to get drivers in first), so I can do either,
though I thought it would be good practice to switch to the now-preferred
format and not have to add any more compatibles to the exception list.
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
index b3f702cbed87..de7bb8b8d85e 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
@@ -35,6 +35,7 @@  Required properties:
  * "qcom,scm-sm8250"
  * "qcom,scm-sm8350"
  * "qcom,scm-sm8450"
+ * "qcom,sm6375-scm"
  and:
  * "qcom,scm"
 - clocks: Specifies clocks needed by the SCM interface, if any: