| Message ID | 20220720073604.1.I249596c011ff05da5a95d72fc321e115ef859803@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade | expand |
On 20/07/2022 09:37, Yunlong Jia wrote: > SKU6 is LTE(w/o eSIM)+WIFI+Parade > > Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com> > --- Didn't you send a v1 already to which I responded? You need to properly version your patches and address all comments, not just some. Best regards, Krzysztof
Hi, On Wed, Jul 20, 2022 at 12:37 AM Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com> wrote: > > SKU6 is LTE(w/o eSIM)+WIFI+Parade > > Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com> > --- > > arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts > index 764c451c1a857..767cb7450c0d8 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts > @@ -14,7 +14,7 @@ > > / { > model = "Google Pazquel (Parade,LTE)"; > - compatible = "google,pazquel-sku4", "qcom,sc7180"; > + compatible = "google,pazquel-sku6", "google,pazquel-sku4", "qcom,sc7180"; Now this doesn't match the bindings. The bindings list 4 first and then 6. You are listing 6 first then 4. The order doesn't really matter, but the two places need to match. As Krzysztof says, you should be incrementing the version of your patches, adding some history, and you should also put the two patches in one series. I believe you're using patman, so something like this and have _both_ changes applied and send them out. In patch #1 (the bindings): Series-changes: 3 - Bindings and dts in the same series. In patch #2 (the dts): Series-version: 3 Series-changes: 2 - Put sku6 before sku4 Series-changes: 3 - Bindings and dts in the same series. -Doug
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts index 764c451c1a857..767cb7450c0d8 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts @@ -14,7 +14,7 @@ / { model = "Google Pazquel (Parade,LTE)"; - compatible = "google,pazquel-sku4", "qcom,sc7180"; + compatible = "google,pazquel-sku6", "google,pazquel-sku4", "qcom,sc7180"; }; &ap_sar_sensor_i2c {
SKU6 is LTE(w/o eSIM)+WIFI+Parade Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com> --- arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)