diff mbox series

[2/2] dt-bindings: arm: qcom: Document additional sa8540p device

Message ID 20220721154413.15578-1-quic_ppareek@quicinc.com (mailing list archive)
State Changes Requested
Headers show
Series [1/2] arm64: dts: qcom: introduce sa8540p-ride dts | expand

Commit Message

Parikshit Pareek July 21, 2022, 3:44 p.m. UTC
Add the ADP ride device to the valid device compatibles found on the
sa8540p platform.

Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski July 21, 2022, 4:27 p.m. UTC | #1
On 21/07/2022 17:44, Parikshit Pareek wrote:
> Add the ADP ride device to the valid device compatibles found on the
> sa8540p platform.
> 
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Krzysztof Kozlowski July 21, 2022, 4:31 p.m. UTC | #2
On 21/07/2022 17:44, Parikshit Pareek wrote:
> Add the ADP ride device to the valid device compatibles found on the
> sa8540p platform.
> 
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>

Bindings are always first commit, otherwise your patchset is not bisectable.

Best regards,
Krzysztof
Konrad Dybcio July 21, 2022, 6:42 p.m. UTC | #3
On 21.07.2022 17:44, Parikshit Pareek wrote:
> Add the ADP ride device to the valid device compatibles found on the
> sa8540p platform.
> 
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
The bindings patch should come before the one that introduces code
that's being documented.

Konrad
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index c566276856ad..5729ce19eb16 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -650,6 +650,7 @@ properties:
>        - items:
>            - enum:
>                - qcom,sa8295p-adp
> +              - qcom,sa8540p-adp-ride
>            - const: qcom,sa8540p
>  
>        - items:
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index c566276856ad..5729ce19eb16 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -650,6 +650,7 @@  properties:
       - items:
           - enum:
               - qcom,sa8295p-adp
+              - qcom,sa8540p-adp-ride
           - const: qcom,sa8540p
 
       - items: