| Message ID | 20220724073650.16460-1-wangjianli@cdjrlc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | msm/adreno: fix repeated words in comments | expand |
On 24/07/2022 10:36, wangjianli wrote: > Delete the redundant word 'in'. Could you please: - adjust the commit subject to follow the rest of commit messages, - drop the extra whitespace at the beginning of the commit message, - add a correct Fixes tag. Thank you > > Signed-off-by: wangjianli <wangjianli@cdjrlc.com> > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > index 9f76f5b15759..9303a011b81d 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -1277,7 +1277,7 @@ static int a6xx_gmu_rpmh_arc_votes_init(struct device *dev, u32 *votes, > } > > /* > - * Look for a level in in the secondary list that matches. If > + * Look for a level in the secondary list that matches. If > * nothing fits, use the maximum non zero vote > */ >
On Fri, Aug 26, 2022 at 12:45:09PM +0300, Dmitry Baryshkov wrote: > On 24/07/2022 10:36, wangjianli wrote: > > Delete the redundant word 'in'. > > Could you please: > - adjust the commit subject to follow the rest of commit messages, > - drop the extra whitespace at the beginning of the commit message, > - add a correct Fixes tag. This doesn't fix a bug so the fixes tag is inappropriate. regards, dan carpenter
On 26/08/2022 12:53, Dan Carpenter wrote: > On Fri, Aug 26, 2022 at 12:45:09PM +0300, Dmitry Baryshkov wrote: >> On 24/07/2022 10:36, wangjianli wrote: >>> Delete the redundant word 'in'. >> >> Could you please: >> - adjust the commit subject to follow the rest of commit messages, >> - drop the extra whitespace at the beginning of the commit message, >> - add a correct Fixes tag. > > This doesn't fix a bug so the fixes tag is inappropriate. Well, it fixes a typo, but I see your point. Let's not insist on Fixes for the comment fixes.
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c index 9f76f5b15759..9303a011b81d 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -1277,7 +1277,7 @@ static int a6xx_gmu_rpmh_arc_votes_init(struct device *dev, u32 *votes, } /* - * Look for a level in in the secondary list that matches. If + * Look for a level in the secondary list that matches. If * nothing fits, use the maximum non zero vote */
Delete the redundant word 'in'. Signed-off-by: wangjianli <wangjianli@cdjrlc.com> --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)