diff mbox series

[v3,1/5] ARM: qcom_defconfig: enable more Qualcomm drivers

Message ID 20220726150609.140472-2-krzysztof.kozlowski@linaro.org (mailing list archive)
State Superseded
Headers show
Series ARM: qcom: defconfig: socinfo + cleanup | expand

Commit Message

Krzysztof Kozlowski July 26, 2022, 3:06 p.m. UTC
Enable Qualcomm drivers:
1. socinfo driver to provide some basic information about the
   SoC being used.
2. Remote filesystem memory driver (used in MSM8974).
3. RPM Power domain (used in MSM8226).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/configs/qcom_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Dmitry Baryshkov July 26, 2022, 4:49 p.m. UTC | #1
On Tue, 26 Jul 2022 at 18:06, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Enable Qualcomm drivers:
> 1. socinfo driver to provide some basic information about the
>    SoC being used.
> 2. Remote filesystem memory driver (used in MSM8974).
> 3. RPM Power domain (used in MSM8226).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm/configs/qcom_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
> index 5cd935ee148a..f02448187eac 100644
> --- a/arch/arm/configs/qcom_defconfig
> +++ b/arch/arm/configs/qcom_defconfig
> @@ -247,12 +247,15 @@ CONFIG_QCOM_COMMAND_DB=y
>  CONFIG_QCOM_GSBI=y
>  CONFIG_QCOM_OCMEM=y
>  CONFIG_QCOM_PM=y
> +CONFIG_QCOM_RMTFS_MEM=y
> +CONFIG_QCOM_RPMPD=y
>  CONFIG_QCOM_SMEM=y
>  CONFIG_QCOM_SMD_RPM=y
>  CONFIG_QCOM_SMP2P=y
>  CONFIG_QCOM_SMSM=y
>  CONFIG_QCOM_RPMH=y
>  CONFIG_QCOM_RPMHPD=y
> +CONFIG_QCOM_SOCINFO=y

please add:
CONFIG_QCOM_STATS=y

>  CONFIG_QCOM_WCNSS_CTRL=y
>  CONFIG_EXTCON_QCOM_SPMI_MISC=y
>  CONFIG_IIO=y
> --
> 2.34.1
>
Krzysztof Kozlowski July 26, 2022, 5:30 p.m. UTC | #2
On 26/07/2022 18:49, Dmitry Baryshkov wrote:
> On Tue, 26 Jul 2022 at 18:06, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Enable Qualcomm drivers:
>> 1. socinfo driver to provide some basic information about the
>>    SoC being used.
>> 2. Remote filesystem memory driver (used in MSM8974).
>> 3. RPM Power domain (used in MSM8226).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  arch/arm/configs/qcom_defconfig | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
>> index 5cd935ee148a..f02448187eac 100644
>> --- a/arch/arm/configs/qcom_defconfig
>> +++ b/arch/arm/configs/qcom_defconfig
>> @@ -247,12 +247,15 @@ CONFIG_QCOM_COMMAND_DB=y
>>  CONFIG_QCOM_GSBI=y
>>  CONFIG_QCOM_OCMEM=y
>>  CONFIG_QCOM_PM=y
>> +CONFIG_QCOM_RMTFS_MEM=y
>> +CONFIG_QCOM_RPMPD=y
>>  CONFIG_QCOM_SMEM=y
>>  CONFIG_QCOM_SMD_RPM=y
>>  CONFIG_QCOM_SMP2P=y
>>  CONFIG_QCOM_SMSM=y
>>  CONFIG_QCOM_RPMH=y
>>  CONFIG_QCOM_RPMHPD=y
>> +CONFIG_QCOM_SOCINFO=y
> 
> please add:
> CONFIG_QCOM_STATS=y

I was considering it, but it seems none of ARMv7 DTS use it.

Best regards,
Krzysztof
Dmitry Baryshkov July 26, 2022, 5:43 p.m. UTC | #3
On 26/07/2022 20:30, Krzysztof Kozlowski wrote:
> On 26/07/2022 18:49, Dmitry Baryshkov wrote:
>> On Tue, 26 Jul 2022 at 18:06, Krzysztof Kozlowski
>> <krzysztof.kozlowski@linaro.org> wrote:
>>>
>>> Enable Qualcomm drivers:
>>> 1. socinfo driver to provide some basic information about the
>>>     SoC being used.
>>> 2. Remote filesystem memory driver (used in MSM8974).
>>> 3. RPM Power domain (used in MSM8226).
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>>   arch/arm/configs/qcom_defconfig | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
>>> index 5cd935ee148a..f02448187eac 100644
>>> --- a/arch/arm/configs/qcom_defconfig
>>> +++ b/arch/arm/configs/qcom_defconfig
>>> @@ -247,12 +247,15 @@ CONFIG_QCOM_COMMAND_DB=y
>>>   CONFIG_QCOM_GSBI=y
>>>   CONFIG_QCOM_OCMEM=y
>>>   CONFIG_QCOM_PM=y
>>> +CONFIG_QCOM_RMTFS_MEM=y
>>> +CONFIG_QCOM_RPMPD=y
>>>   CONFIG_QCOM_SMEM=y
>>>   CONFIG_QCOM_SMD_RPM=y
>>>   CONFIG_QCOM_SMP2P=y
>>>   CONFIG_QCOM_SMSM=y
>>>   CONFIG_QCOM_RPMH=y
>>>   CONFIG_QCOM_RPMHPD=y
>>> +CONFIG_QCOM_SOCINFO=y
>>
>> please add:
>> CONFIG_QCOM_STATS=y
> 
> I was considering it, but it seems none of ARMv7 DTS use it.

Argh. The driver has support for 8974 and 8084, but nobody has wired 
that up. I'd still suggest marking it as =y/=m. I'll send dtsi patches 
in parallel.
Stephan Gerhold July 26, 2022, 5:54 p.m. UTC | #4
On Tue, Jul 26, 2022 at 07:30:12PM +0200, Krzysztof Kozlowski wrote:
> On 26/07/2022 18:49, Dmitry Baryshkov wrote:
> > On Tue, 26 Jul 2022 at 18:06, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> Enable Qualcomm drivers:
> >> 1. socinfo driver to provide some basic information about the
> >>    SoC being used.
> >> 2. Remote filesystem memory driver (used in MSM8974).
> >> 3. RPM Power domain (used in MSM8226).
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >>  arch/arm/configs/qcom_defconfig | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
> >> index 5cd935ee148a..f02448187eac 100644
> >> --- a/arch/arm/configs/qcom_defconfig
> >> +++ b/arch/arm/configs/qcom_defconfig
> >> @@ -247,12 +247,15 @@ CONFIG_QCOM_COMMAND_DB=y
> >>  CONFIG_QCOM_GSBI=y
> >>  CONFIG_QCOM_OCMEM=y
> >>  CONFIG_QCOM_PM=y
> >> +CONFIG_QCOM_RMTFS_MEM=y
> >> +CONFIG_QCOM_RPMPD=y
> >>  CONFIG_QCOM_SMEM=y
> >>  CONFIG_QCOM_SMD_RPM=y
> >>  CONFIG_QCOM_SMP2P=y
> >>  CONFIG_QCOM_SMSM=y
> >>  CONFIG_QCOM_RPMH=y
> >>  CONFIG_QCOM_RPMHPD=y
> >> +CONFIG_QCOM_SOCINFO=y
> > 
> > please add:
> > CONFIG_QCOM_STATS=y
> 
> I was considering it, but it seems none of ARMv7 DTS use it.
> 

Some MSM8916 boards are used on ARMv7 (due to firmware limitations)
and the msm8916.dtsi has it. :)

Thanks,
Stephan
Krzysztof Kozlowski July 27, 2022, 6:51 a.m. UTC | #5
On 26/07/2022 19:54, Stephan Gerhold wrote:
> On Tue, Jul 26, 2022 at 07:30:12PM +0200, Krzysztof Kozlowski wrote:
>> On 26/07/2022 18:49, Dmitry Baryshkov wrote:
>>> On Tue, 26 Jul 2022 at 18:06, Krzysztof Kozlowski
>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>
>>>> Enable Qualcomm drivers:
>>>> 1. socinfo driver to provide some basic information about the
>>>>    SoC being used.
>>>> 2. Remote filesystem memory driver (used in MSM8974).
>>>> 3. RPM Power domain (used in MSM8226).
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> ---
>>>>  arch/arm/configs/qcom_defconfig | 3 +++
>>>>  1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
>>>> index 5cd935ee148a..f02448187eac 100644
>>>> --- a/arch/arm/configs/qcom_defconfig
>>>> +++ b/arch/arm/configs/qcom_defconfig
>>>> @@ -247,12 +247,15 @@ CONFIG_QCOM_COMMAND_DB=y
>>>>  CONFIG_QCOM_GSBI=y
>>>>  CONFIG_QCOM_OCMEM=y
>>>>  CONFIG_QCOM_PM=y
>>>> +CONFIG_QCOM_RMTFS_MEM=y
>>>> +CONFIG_QCOM_RPMPD=y
>>>>  CONFIG_QCOM_SMEM=y
>>>>  CONFIG_QCOM_SMD_RPM=y
>>>>  CONFIG_QCOM_SMP2P=y
>>>>  CONFIG_QCOM_SMSM=y
>>>>  CONFIG_QCOM_RPMH=y
>>>>  CONFIG_QCOM_RPMHPD=y
>>>> +CONFIG_QCOM_SOCINFO=y
>>>
>>> please add:
>>> CONFIG_QCOM_STATS=y
>>
>> I was considering it, but it seems none of ARMv7 DTS use it.
>>
> 
> Some MSM8916 boards are used on ARMv7 (due to firmware limitations)
> and the msm8916.dtsi has it. :)

OK, thanks!


Best regards,
Krzysztof
Krzysztof Kozlowski July 27, 2022, 6:51 a.m. UTC | #6
On 26/07/2022 19:43, Dmitry Baryshkov wrote:

>> I was considering it, but it seems none of ARMv7 DTS use it.
> 
> Argh. The driver has support for 8974 and 8084, but nobody has wired 
> that up. I'd still suggest marking it as =y/=m. I'll send dtsi patches 
> in parallel.
> 

OK, that makes sense. I'll add it to defconfigs.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
index 5cd935ee148a..f02448187eac 100644
--- a/arch/arm/configs/qcom_defconfig
+++ b/arch/arm/configs/qcom_defconfig
@@ -247,12 +247,15 @@  CONFIG_QCOM_COMMAND_DB=y
 CONFIG_QCOM_GSBI=y
 CONFIG_QCOM_OCMEM=y
 CONFIG_QCOM_PM=y
+CONFIG_QCOM_RMTFS_MEM=y
+CONFIG_QCOM_RPMPD=y
 CONFIG_QCOM_SMEM=y
 CONFIG_QCOM_SMD_RPM=y
 CONFIG_QCOM_SMP2P=y
 CONFIG_QCOM_SMSM=y
 CONFIG_QCOM_RPMH=y
 CONFIG_QCOM_RPMHPD=y
+CONFIG_QCOM_SOCINFO=y
 CONFIG_QCOM_WCNSS_CTRL=y
 CONFIG_EXTCON_QCOM_SPMI_MISC=y
 CONFIG_IIO=y