| Message ID | 20220809034346.128607-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | thermal/drivers/qcom/spmi-adc-tm5: Remove unnecessary print function dev_err() | expand |
On Mon 08 Aug 22:43 CDT 2022, Jiapeng Chong wrote: > The print function dev_err() is redundant because platform_get_irq() > already prints an error. > > ./drivers/thermal/qcom/qcom-spmi-adc-tm5.c:1029:2-9: line 1029 is redundant because platform_get_irq() already prints an error. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1846 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c > index add6f40e5e2a..af68adf720cc 100644 > --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c > +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c > @@ -1025,10 +1025,8 @@ static int adc_tm5_probe(struct platform_device *pdev) > adc_tm->base = reg; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "get_irq failed: %d\n", irq); > + if (irq < 0) > return irq; > - } > > ret = adc_tm5_get_dt_data(adc_tm, node); > if (ret) { > -- > 2.20.1.7.g153144c >
diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c index add6f40e5e2a..af68adf720cc 100644 --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c @@ -1025,10 +1025,8 @@ static int adc_tm5_probe(struct platform_device *pdev) adc_tm->base = reg; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "get_irq failed: %d\n", irq); + if (irq < 0) return irq; - } ret = adc_tm5_get_dt_data(adc_tm, node); if (ret) {
The print function dev_err() is redundant because platform_get_irq() already prints an error. ./drivers/thermal/qcom/qcom-spmi-adc-tm5.c:1029:2-9: line 1029 is redundant because platform_get_irq() already prints an error. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1846 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)