From patchwork Thu Aug 25 16:42:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 12955077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B914DECAA27 for ; Thu, 25 Aug 2022 16:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243279AbiHYQne (ORCPT ); Thu, 25 Aug 2022 12:43:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241729AbiHYQnK (ORCPT ); Thu, 25 Aug 2022 12:43:10 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FEF3BBA52 for ; Thu, 25 Aug 2022 09:42:39 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id 67so12135736pfv.2 for ; Thu, 25 Aug 2022 09:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=d4UI1F2bYQXxMhQ+dzwb24OzDE0AWn6jHagvx1unuTc=; b=j2TmCgWoyZB+Cpo//y2pL0iJWB6+3zKzqNBOT20pGN+dgBTtvknEH0+UTM8TAdCzVh dysJKTPjXyAB3UBpzQ2T3oOwomVdTHtN+4gQjAY5UA/sRo5XCxJETvStIXM8Incpygzr R7nZ1AFZAw2wD44wIiNTkupLmmp6c+QtnnQ4Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=d4UI1F2bYQXxMhQ+dzwb24OzDE0AWn6jHagvx1unuTc=; b=oYDy0nXyb/8lO0b7woA7Nzu0pN9ZnLKSxUSsvi8g9ED2nB8sg2Hw0glrP+edaNNMhI DU6MEMAA66sOkvb3q06QyczTx3YYNY1reheETQRIjlDtK/3BrfOjfo81lnvl5o1UiBR0 rdJzLKv6Uo8nHrq4YF0DbKPzAKZk6+wEXE+Cqb4pVl8Gkw+RMLeOZZPPu5MDbpCSKVmk 6dYZNyQ41WFz22YybmdwuKG8f3/QAMYIzdv1lvIuNjvMcHm1FIHMUto0ScpejuwduCsK aWGQLnPL6y8NJ9s5QstxmPt7vxmztaXV73No0ptOhPP7tsWnQsPvWPiq5Cp7pHMW73Ri kZqQ== X-Gm-Message-State: ACgBeo2SVDNR/unG+Xiy38CSRJ3tqaEsUaRLTOciCq76pZlRePaMCCtd m50UYC8CAQacvDPu4n0p/Qqnqg== X-Google-Smtp-Source: AA6agR7oIU56o6vD6pTE3YQcipHjvbw7cxpA0pM2NX2Adpgu6SmRbTACnoc2Kt822IR83Vn0HGDAFQ== X-Received: by 2002:a65:6e82:0:b0:41a:9b73:f0e6 with SMTP id bm2-20020a656e82000000b0041a9b73f0e6mr4049513pgb.371.1661445758192; Thu, 25 Aug 2022 09:42:38 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:b7f2:d739:e847:6e53]) by smtp.gmail.com with ESMTPSA id y13-20020a17090a154d00b001f2ef3c7956sm3775799pja.25.2022.08.25.09.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 09:42:37 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Andrew Halaney , Mark Brown , Douglas Anderson , Andy Gross , Johan Hovold , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] arm64: dts: qcom: sc8280xp-thinkpad-x13s: Specify which LDO modes are allowed Date: Thu, 25 Aug 2022 09:42:02 -0700 Message-Id: <20220825094155.4.I897770a7ac41f8dc3e37dfed12102bacdbf9da56@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220825164205.4060647-1-dianders@chromium.org> References: <20220825164205.4060647-1-dianders@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid Fixes: 32c231385ed4 ("arm64: dts: qcom: sc8280xp: add Lenovo Thinkpad X13s devicetree") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index 16c6e4d920bb..0c2534b4ec24 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -80,6 +80,9 @@ vreg_l3b: ldo3 { regulator-max-microvolt = <1200000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; regulator-boot-on; }; @@ -89,6 +92,9 @@ vreg_l4b: ldo4 { regulator-max-microvolt = <912000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l6b: ldo6 { @@ -97,6 +103,9 @@ vreg_l6b: ldo6 { regulator-max-microvolt = <880000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; regulator-boot-on; regulator-always-on; // FIXME: VDD_A_EDP_0_0P9 }; @@ -112,6 +121,9 @@ vreg_l1c: ldo1 { regulator-max-microvolt = <1800000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l12c: ldo12 { @@ -120,6 +132,9 @@ vreg_l12c: ldo12 { regulator-max-microvolt = <1800000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l13c: ldo13 { @@ -128,6 +143,9 @@ vreg_l13c: ldo13 { regulator-max-microvolt = <3072000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; }; @@ -143,6 +161,9 @@ vreg_l3d: ldo3 { regulator-max-microvolt = <1200000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l4d: ldo4 { @@ -151,6 +172,9 @@ vreg_l4d: ldo4 { regulator-max-microvolt = <1200000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l7d: ldo7 { @@ -159,6 +183,9 @@ vreg_l7d: ldo7 { regulator-max-microvolt = <3072000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l9d: ldo9 { @@ -167,6 +194,9 @@ vreg_l9d: ldo9 { regulator-max-microvolt = <912000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; }; };