| Message ID | 20220826123547.3392457-2-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: pwm: Drop PWM reg dependency | expand |
On 26/08/2022 15:35, Bryan O'Donoghue wrote: > Drop the reg dependency from the qcom PWM description. > > The PWM driver doesn't depend on the reg so we should drop the dependency > and remove the pwm@reg from the nodename. Driver is not really a sufficient reason. Based on https://lore.kernel.org/all/CAA8EJppGS38aP7gyd1c3kNgraAVJDoqUef2cDfZpu2aL_iwW0g@mail.gmail.com/ reason could be: The PWM node is not a separate device and is expected to be part of parent SPMI PMIC node, thus it obtains the address space from the parent. One IO address in "reg" is also not correct description because LPG block maps to several regions. > > Fixes: e79a1385ab74 ("arm64: dts: qcom: Add LPG to pm8916, pm8994, pmi8994 and pmi8998") > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++---- > arch/arm64/boot/dts/qcom/pm8350c.dtsi | 3 +-- Patches should be split. One patchset, but two patches. > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > index 65cbc6dee545e..2a5bafe0660a0 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > @@ -92,6 +92,10 @@ properties: > type: object > $ref: /schemas/regulator/regulator.yaml# > Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 65cbc6dee545e..2a5bafe0660a0 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -92,6 +92,10 @@ properties: type: object $ref: /schemas/regulator/regulator.yaml# + pwm: + type: object + $ref: /schemas/leds/leds-qcom-lpg.yaml# + patternProperties: "^adc@[0-9a-f]+$": type: object @@ -117,10 +121,6 @@ patternProperties: type: object $ref: /schemas/power/reset/qcom,pon.yaml# - "pwm@[0-9a-f]+$": - type: object - $ref: /schemas/leds/leds-qcom-lpg.yaml# - "^rtc@[0-9a-f]+$": type: object $ref: /schemas/rtc/qcom-pm8xxx-rtc.yaml# diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi index e0bbb67717fec..f28e71487d5c7 100644 --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi @@ -30,9 +30,8 @@ pm8350c_gpios: gpio@8800 { #interrupt-cells = <2>; }; - pm8350c_pwm: pwm@e800 { + pm8350c_pwm: pwm { compatible = "qcom,pm8350c-pwm"; - reg = <0xe800>; #pwm-cells = <2>; status = "disabled"; };
Drop the reg dependency from the qcom PWM description. The PWM driver doesn't depend on the reg so we should drop the dependency and remove the pwm@reg from the nodename. Fixes: e79a1385ab74 ("arm64: dts: qcom: Add LPG to pm8916, pm8994, pmi8994 and pmi8998") Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++---- arch/arm64/boot/dts/qcom/pm8350c.dtsi | 3 +-- 2 files changed, 5 insertions(+), 6 deletions(-)