| Message ID | 20220828205723.20834-2-joelselvaraj.oss@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for Xiaomi Poco F1 EBBG variant | expand |
On 28/08/2022 23:57, Joel Selvaraj wrote: > There are two panel variants of Xiaomi Poco F1. Tianma and EBBG panel. > The previous beryllium dts supported the Tianma variant. In order to > add support for EBBG variant, the common nodes from beryllium dts are > moved to a new common dtsi and to make the variants distinguishable, > sdm845-xiaomi-beryllium.dts is now named as > sdm845-xiaomi-beryllium-tianma.dts. The board's model and compatible > properties are also renamed to distinguish between the variants. > So update the dt-bindings to reflect the new compatible value. > > Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index fb1d00bcc847..e465ca45c07f 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -666,7 +666,7 @@ properties: > - sony,akatsuki-row > - sony,apollo-row > - thundercomm,db845c > - - xiaomi,beryllium > + - xiaomi,beryllium-tianma The board compatibles are not that important for ABI yet this creates precedence, so I am against it. Simple renaming should not be a reason to change compatibles. Best regards, Krzysztof
Hi Krzysztof Kozlowski, > The board compatibles are not that important for ABI yet this creates > precedence, so I am against it. Simple renaming should not be a reason > to change compatibles. So what should I do now? 1. Retain "xiaomi,beryllium" for tianma and "xiaomi,beryllium-ebbg" for ebbg? 2. If adding new compatible is not an issue, can I do "xiaomi,beryllium-tianma", "xiaomi,beryllium", "qcom,sdm845" - for tianma "xiaomi,beryllium-ebbg", "xiaomi,beryllium", "qcom,sdm845" - for ebbg Kindly let me know if any other possible solution is present. Thank you, Joel Selvaraj
On 02/09/2022 07:20, Joel Selvaraj wrote: > Hi Krzysztof Kozlowski, > >> The board compatibles are not that important for ABI yet this creates >> precedence, so I am against it. Simple renaming should not be a reason >> to change compatibles. > > So what should I do now? > 1. Retain "xiaomi,beryllium" for tianma and "xiaomi,beryllium-ebbg" for ebbg? > 2. If adding new compatible is not an issue, can I do > "xiaomi,beryllium-tianma", "xiaomi,beryllium", "qcom,sdm845" - for tianma > "xiaomi,beryllium-ebbg", "xiaomi,beryllium", "qcom,sdm845" - for ebbg > Both options work for me. I understand that boards are quite compatible and only the panel is different but the safest option (from any 3rd party users) is (1) above. If anyone has other preference, I am also ok. If not, then go with (1) above. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index fb1d00bcc847..e465ca45c07f 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -666,7 +666,7 @@ properties: - sony,akatsuki-row - sony,apollo-row - thundercomm,db845c - - xiaomi,beryllium + - xiaomi,beryllium-tianma - xiaomi,polaris - const: qcom,sdm845
There are two panel variants of Xiaomi Poco F1. Tianma and EBBG panel. The previous beryllium dts supported the Tianma variant. In order to add support for EBBG variant, the common nodes from beryllium dts are moved to a new common dtsi and to make the variants distinguishable, sdm845-xiaomi-beryllium.dts is now named as sdm845-xiaomi-beryllium-tianma.dts. The board's model and compatible properties are also renamed to distinguish between the variants. So update the dt-bindings to reflect the new compatible value. Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)