From patchwork Mon Aug 29 16:49:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 12958204 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8E17C0502F for ; Mon, 29 Aug 2022 16:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbiH2QuU (ORCPT ); Mon, 29 Aug 2022 12:50:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbiH2QuT (ORCPT ); Mon, 29 Aug 2022 12:50:19 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D1BD564EB for ; Mon, 29 Aug 2022 09:50:17 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id f24so5815388plr.1 for ; Mon, 29 Aug 2022 09:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=/JqFRsfWc9SAzvod+scKS9vCJ/82zulusd10VvDyv/U=; b=k/bSbr13oFJgDwbXV7O3MysZvt1jGmJvRITnPBuHM+KO0HO0Yn5/m8e7G0rDhxcUdu MbdpxQLMOwIIfw16H0JoOhRnRkcROUuSgg9K9+WXlJj2oZGV9nq+r6Ex4eYUJGv/jKoD 3FlrMucgfLYmWwcz4I+KgVkTdLIMjw7pArRso= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=/JqFRsfWc9SAzvod+scKS9vCJ/82zulusd10VvDyv/U=; b=YMUkULpK4PLOnoQ3P2/voD3jhRID1y6Vbab0itSlMlVtctDzXqV3R0O6NxuS4MmGUF dGtx9wQH0SzFK980vBSiMWDcXkd7xVNfavZUCrw1K3dUBousX+XMsvFhVQDSykTk9KQR vbcyvAnwTkuKt1gDILmFCzDttBi/m2TeieAXOsFnmw0FPsvj8fXGj/GxRZnceldcYEtC WyQa8wNiorTvaWA4zcRA82zQQeZ0OZ1KPTva8vQyAHjsPdbjHX0duw4oqJbIXwOtFHQ2 TRH+0YvhyQCTn8bO8tPPW9xQ6t7noN/5A5LXujZKBIGULB+MRkQ3WfxRSTGh7GsdvaCG LrvQ== X-Gm-Message-State: ACgBeo1m/nIfaZAH+YVI0NWwJxEahTrl1UYIKsuFyjRstyCstZlDKO6v sP96HGZGNRRfPp93mMzsB/bFZA== X-Google-Smtp-Source: AA6agR6a+oYSlVo22PUDaC+EZo/UuSwM2itcan9ouOvKUC3GSZN8+L4ll/q2sZeyrbhRfXBY2PqbIQ== X-Received: by 2002:a17:90b:4f4e:b0:1f5:8a65:9192 with SMTP id pj14-20020a17090b4f4e00b001f58a659192mr18973833pjb.224.1661791816976; Mon, 29 Aug 2022 09:50:16 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:3a97:5017:7e33:8964]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b001729db603bcsm7864238plg.126.2022.08.29.09.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 09:50:16 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Johan Hovold , Andrew Halaney , Mark Brown , Douglas Anderson , Konrad Dybcio , Andy Gross , Bhupesh Sharma , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/6] arm64: dts: qcom: sa8155p-adp: Specify which LDO modes are allowed Date: Mon, 29 Aug 2022 09:49:47 -0700 Message-Id: <20220829094903.v2.1.Id59c32b560c4662d8b3697de2bd494d08d654806@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220829164952.2672848-1-dianders@chromium.org> References: <20220829164952.2672848-1-dianders@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. NOTE: while here, let's also remove the nonsensical "regulator-allow-set-load" on the fixed regulator "vreg_s4a_1p8". [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid Fixes: 5b85e8f2225c ("arm64: dts: qcom: sa8155p-adp: Add base dts file") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- Changes in v2: - Added note about removing regulator-allow-set-load from vreg_s4a_1p8 arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index ba547ca9fc6b..ddb9cb182152 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -43,7 +43,6 @@ vreg_s4a_1p8: smps4 { regulator-always-on; regulator-boot-on; - regulator-allow-set-load; vin-supply = <&vreg_3p3>; }; @@ -137,6 +136,9 @@ vreg_l5a_0p88: ldo5 { regulator-max-microvolt = <880000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l7a_1p8: ldo7 { @@ -152,6 +154,9 @@ vreg_l10a_2p96: ldo10 { regulator-max-microvolt = <2960000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l11a_0p8: ldo11 { @@ -258,6 +263,9 @@ vreg_l5c_1p2: ldo5 { regulator-max-microvolt = <1200000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l7c_1p8: ldo7 { @@ -273,6 +281,9 @@ vreg_l8c_1p2: ldo8 { regulator-max-microvolt = <1200000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l10c_3p3: ldo10 {