diff mbox series

[linux-next] media: venus: hfi: Remove the unneeded result variable

Message ID 20220830083753.276861-1-ye.xingchen@zte.com.cn (mailing list archive)
State Not Applicable
Headers show
Series [linux-next] media: venus: hfi: Remove the unneeded result variable | expand

Commit Message

CGEL Aug. 30, 2022, 8:37 a.m. UTC 
From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value venus_hfi_create() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/media/platform/qcom/venus/hfi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Krzysztof Kozlowski Aug. 30, 2022, 7:10 p.m. UTC | #1 
On 30/08/2022 11:37, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value venus_hfi_create() directly instead of storing it in
> another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>

Reported-by is used for crediting bug reporters. There is no bug here.
Stop abusing the kernel tags.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers/media/platform/qcom/venus/hfi.c
index 1968f09ad177..e00aedb41d16 100644
--- a/drivers/media/platform/qcom/venus/hfi.c
+++ b/drivers/media/platform/qcom/venus/hfi.c
@@ -569,8 +569,6 @@  irqreturn_t hfi_isr(int irq, void *dev)
 
 int hfi_create(struct venus_core *core, const struct hfi_core_ops *ops)
 {
-	int ret;
-
 	if (!ops)
 		return -EINVAL;
 
@@ -579,9 +577,8 @@  int hfi_create(struct venus_core *core, const struct hfi_core_ops *ops)
 	core->state = CORE_UNINIT;
 	init_completion(&core->done);
 	pkt_set_version(core->res->hfi_version);
-	ret = venus_hfi_create(core);
 
-	return ret;
+	return venus_hfi_create(core);
 }
 
 void hfi_destroy(struct venus_core *core)