diff mbox series

[v2,1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360

Message ID 20220830112013.v2.1.Ic4d4e0777115011544dbc2ab07ed4d7b408c003a@changeid (mailing list archive)
State Superseded
Headers show
Series [v2,1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 | expand

Commit Message

Yunlong Jia Aug. 30, 2022, 11:21 a.m. UTC 
pazquel360 is an extension project based on pazquel.
We create 3 sku on pazquel360:
   sku 20 for LTE with physical SIM _and_ eSIM and WiFi
   sku 21 for WiFi only
   sku 22 for LTE with only a physical SIM
 Both sku20 and sku22 are LTE SKUs.
 One has the eSIM stuffed and one doesn't.
 There is a single shared device tree for the two.

Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---

(no changes since v1)

 Documentation/devicetree/bindings/arm/qcom.yaml | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Krzysztof Kozlowski Aug. 30, 2022, 11:29 a.m. UTC | #1 
On 30/08/2022 14:21, Yunlong Jia wrote:
> pazquel360 is an extension project based on pazquel.
> We create 3 sku on pazquel360:
>    sku 20 for LTE with physical SIM _and_ eSIM and WiFi
>    sku 21 for WiFi only
>    sku 22 for LTE with only a physical SIM
>  Both sku20 and sku22 are LTE SKUs.
>  One has the eSIM stuffed and one doesn't.
>  There is a single shared device tree for the two.
> 
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
> 
> (no changes since v1)
> 

It's the fourth sending of v2, of which three were sent today. I asked
you to read the document before sending. Really, please read it.

Version your patches correctly and add some time before resends.

Best regards,
Krzysztof
Krzysztof Kozlowski Aug. 30, 2022, 12:23 p.m. UTC | #2 
On 30/08/2022 15:20, Yunlong Jia wrote:
> Got it.
>>
>> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
>> ---
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>>
>> (no changes since v1)
>>
> Is the above format correct？


The above is not correct. The one in this patch was okay.

The comment was about resending four times the same version. Read the
docs before next posting.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index fb1d00bcc847..851cf5edb582 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -459,6 +459,17 @@  properties:
           - const: google,pazquel-sku2
           - const: qcom,sc7180
 
+      - description: Google Pazquel360 with LTE (newest rev)
+        items:
+          - const: google,pazquel-sku22
+          - const: google,pazquel-sku20
+          - const: qcom,sc7180
+
+      - description: Google Pazquel360 with WiFi (newest rev)
+        items:
+          - const: google,pazquel-sku21
+          - const: qcom,sc7180
+
       - description: Sharp Dynabook Chromebook C1 (rev1)
         items:
           - const: google,pompom-rev1