From patchwork Fri Sep 2 18:51:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 12964521 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44EDDECAAD5 for ; Fri, 2 Sep 2022 18:52:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230018AbiIBSwk (ORCPT ); Fri, 2 Sep 2022 14:52:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbiIBSwi (ORCPT ); Fri, 2 Sep 2022 14:52:38 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3408E2C55 for ; Fri, 2 Sep 2022 11:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662144751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uLJN7/BLiss15VoCQRispsUH3s6wfzk4G5XVQwrvZI0=; b=DEgrurzHMf4AYc0NzQwbCJGPeZc5KAwhBxcAowHu8UvP6w/8X/1XqRyLkXfrUJ7hkrdpjm oRs8ImaPAFXEoh+aV8zStoq/+r1UMT0hGoTaEbThXHf2MUI5z6yQ6vzRhQyLbhXJUpIQUm eVZKFv+Yimbw+/KllSQdXJ1wOLtI1oA= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-176-dp1WnwtqPLuCAMMp25_7UA-1; Fri, 02 Sep 2022 14:52:30 -0400 X-MC-Unique: dp1WnwtqPLuCAMMp25_7UA-1 Received: by mail-qk1-f200.google.com with SMTP id g6-20020a05620a40c600b006bbdeb0b1f2so2615589qko.22 for ; Fri, 02 Sep 2022 11:52:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=uLJN7/BLiss15VoCQRispsUH3s6wfzk4G5XVQwrvZI0=; b=kxN2OP/z/w0JsN3j4wcueC6vQ41fDY6EWMvrXrjQ3WfYary7WvDVeSTPmD60OEbvsO FrKnyYm4gTl/vBoisNNXDVhLIOyiOdK+IqKm8gK0XRUVux2YSbcFXGt3wGn74ESFWnZj M+4M/eOs7Ny0BMIwW7XUFYgld4n0nSFJSZWOIVsAP3DRs2Gw6gAqlYs48vo3YKb2qPyD Be1afE4RoGbAEFi0172G/tBIAtYsHex5wxv9ssHm8BwPGqB8uTQlG3afEtAwIqw3f1wG p7H8k5P0jxP3DCWJsy8aekq+ZKx+Lb5IsHIIVNvFjB+nLYs7F9e9FzL0gCUqzVMwxE6q 53Jw== X-Gm-Message-State: ACgBeo1/UsrOIvvzGssW66g9zdA2iZ5AUPP3rvcN25QSFWQp+/OPRvG1 P8NfhhiSXWvux1fhNZMIOzFQDlispvNmruvOBoJA8iY6SFCnQLLIxAZsPHPTK9PByo82W7WD+z4 KNJd0g+SmrppciPxnpcWMmDp9Cg== X-Received: by 2002:a0c:9d46:0:b0:476:ff07:3fe7 with SMTP id n6-20020a0c9d46000000b00476ff073fe7mr30933299qvf.15.1662144750213; Fri, 02 Sep 2022 11:52:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR7aZwLqxASsgLyT6pr2oLxtShydapkDDS6erqpAYgTyjpgPuDnQlYnCVVNVGOO0dY0TwHgdKg== X-Received: by 2002:a0c:9d46:0:b0:476:ff07:3fe7 with SMTP id n6-20020a0c9d46000000b00476ff073fe7mr30933279qvf.15.1662144749987; Fri, 02 Sep 2022 11:52:29 -0700 (PDT) Received: from halaneylaptop.redhat.com ([2600:1700:1ff0:d0e0::48]) by smtp.gmail.com with ESMTPSA id j4-20020ac874c4000000b0031ef0081d77sm1403168qtr.79.2022.09.02.11.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 11:52:29 -0700 (PDT) From: Andrew Halaney To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, johan@kernel.org, Andrew Halaney Subject: [PATCH 2/3] regulator: dt-bindings: qcom,rpmh: Specify supply property Date: Fri, 2 Sep 2022 13:51:47 -0500 Message-Id: <20220902185148.635292-3-ahalaney@redhat.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220902185148.635292-1-ahalaney@redhat.com> References: <20220902185148.635292-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The top level RPMh nodes have a supply property, make sure to specify it so the patternProperties later that are keyed off of the PMIC version are properly honored. Without this, and the dt-binding containing additionalProperties: false, you will see the following when running make dt_binding_check: DTEX Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dts DTC Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb CHECK Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb: pm8998-rpmh-regulators: 'vdd-l7-l12-l14-l15-supply' does not match any of the regexes: '^(smps|ldo|lvs)[0-9]+$', 'pinctrl-[0-9]+' From schema: /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml That supply pattern is intended to be considered correct for the qcom,pm8998-rpmh-regulators compatible, and is no longer complained about with the supply property described. Unfortunately this pattern is wide enough that it no longer complains when you bork the expected supply for a compatible. I.e. for qcom,pm8998-rpmh-regulators, if I change the example usage in the binding to: vdd-l0-l12-l14-l15-supply = <&pm8998_s5>; I get no warning, when really it should be of the pattern: vdd-l7-l12-l14-l15-supply = <&pm8998_s5>; Signed-off-by: Andrew Halaney --- .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml index b3fd60b21610..86265b513de3 100644 --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml @@ -106,6 +106,9 @@ patternProperties: $ref: "regulator.yaml#" description: smps/ldo regulator nodes(s). + ".*-supply$": + description: Input supply phandle(s) for this node + additionalProperties: false required: