| Message ID | 20220909163416.1021551-2-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Update apq8016 lpass-cpu compat string | expand |
On 09/09/2022 18:34, Bryan O'Donoghue wrote: > We've had some discongruity in the compatible string of the lpass for 8916 > for a while. > > Mark the old compat as deprecated. New SoC additions such as msm8936 and > msm8939 should use the compat string "qcom,apq8016-lpass-cpu". > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > index ef18a572a1ff3..bb6f0c5dd4e8b 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > @@ -18,11 +18,13 @@ description: | > > properties: > compatible: > - enum: > - - qcom,lpass-cpu > - - qcom,apq8016-lpass-cpu > - - qcom,sc7180-lpass-cpu > - - qcom,sc7280-lpass-cpu > + oneOf: > + - const: qcom,lpass-cpu > + - const: qcom,apq8016-lpass-cpu > + - const: qcom,sc7180-lpass-cpu > + - const: qcom,sc7280-lpass-cpu We talked and I gave you the expected code with enum. I also explained why other schema (Odroid sound) is done differently. The code here is correct, but I find more readable and common to use enum. Please make these entries as enum. > + - const: qcom,lpass-cpu-apq8016 > + deprecated: true > > reg: > minItems: 1 Best regards, Krzysztof
On 09/09/2022 17:36, Krzysztof Kozlowski wrote: > On 09/09/2022 18:34, Bryan O'Donoghue wrote: >> We've had some discongruity in the compatible string of the lpass for 8916 >> for a while. >> >> Mark the old compat as deprecated. New SoC additions such as msm8936 and >> msm8939 should use the compat string "qcom,apq8016-lpass-cpu". >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- >> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >> index ef18a572a1ff3..bb6f0c5dd4e8b 100644 >> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >> @@ -18,11 +18,13 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - qcom,lpass-cpu >> - - qcom,apq8016-lpass-cpu >> - - qcom,sc7180-lpass-cpu >> - - qcom,sc7280-lpass-cpu >> + oneOf: >> + - const: qcom,lpass-cpu >> + - const: qcom,apq8016-lpass-cpu >> + - const: qcom,sc7180-lpass-cpu >> + - const: qcom,sc7280-lpass-cpu > > We talked and I gave you the expected code with enum. I also explained > why other schema (Odroid sound) is done differently. The code here is > correct, but I find more readable and common to use enum. Please make > these entries as enum. Ah you did say enum, I copy/pasted the wrong fragment.
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml index ef18a572a1ff3..bb6f0c5dd4e8b 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml @@ -18,11 +18,13 @@ description: | properties: compatible: - enum: - - qcom,lpass-cpu - - qcom,apq8016-lpass-cpu - - qcom,sc7180-lpass-cpu - - qcom,sc7280-lpass-cpu + oneOf: + - const: qcom,lpass-cpu + - const: qcom,apq8016-lpass-cpu + - const: qcom,sc7180-lpass-cpu + - const: qcom,sc7280-lpass-cpu + - const: qcom,lpass-cpu-apq8016 + deprecated: true reg: minItems: 1
We've had some discongruity in the compatible string of the lpass for 8916 for a while. Mark the old compat as deprecated. New SoC additions such as msm8936 and msm8939 should use the compat string "qcom,apq8016-lpass-cpu". Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)