| Message ID | 20220910014206.1101962-2-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Update apq8016 lpass-cpu compat string | expand |
On 10/09/2022 03:42, Bryan O'Donoghue wrote: > We've had some discongruity in the compatible string of the lpass for 8916 > for a while. > > Mark the old compat as deprecated. New SoC additions such as msm8936 and > msm8939 should use the compat string "qcom,apq8016-lpass-cpu". > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > index ef18a572a1ff3..e2c0f573a3084 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > @@ -18,11 +18,14 @@ description: | > > properties: > compatible: > - enum: > - - qcom,lpass-cpu > - - qcom,apq8016-lpass-cpu > - - qcom,sc7180-lpass-cpu > - - qcom,sc7280-lpass-cpu > + oneOf: > + - enum: > + - qcom,lpass-cpu > + - qcom,apq8016-lpass-cpu The indentation looks odd here. Are you sure it passes the `make dt_binding_check`? Best regards, Krzysztof
On 10/09/2022 08:55, Krzysztof Kozlowski wrote: > On 10/09/2022 03:42, Bryan O'Donoghue wrote: >> We've had some discongruity in the compatible string of the lpass for 8916 >> for a while. >> >> Mark the old compat as deprecated. New SoC additions such as msm8936 and >> msm8939 should use the compat string "qcom,apq8016-lpass-cpu". >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- >> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 13 ++++++++----- >> 1 file changed, 8 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >> index ef18a572a1ff3..e2c0f573a3084 100644 >> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >> @@ -18,11 +18,14 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - qcom,lpass-cpu >> - - qcom,apq8016-lpass-cpu >> - - qcom,sc7180-lpass-cpu >> - - qcom,sc7280-lpass-cpu >> + oneOf: >> + - enum: >> + - qcom,lpass-cpu >> + - qcom,apq8016-lpass-cpu > > The indentation looks odd here. Are you sure it passes the `make > dt_binding_check`? It does yeah --- bod
On Sat, 10 Sep 2022 02:42:06 +0100, Bryan O'Donoghue wrote: > We've had some discongruity in the compatible string of the lpass for 8916 > for a while. > > Mark the old compat as deprecated. New SoC additions such as msm8936 and > msm8939 should use the compat string "qcom,apq8016-lpass-cpu". > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml:23:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 10/09/2022 15:53, Rob Herring wrote: > On Sat, 10 Sep 2022 02:42:06 +0100, Bryan O'Donoghue wrote: >> We've had some discongruity in the compatible string of the lpass for 8916 >> for a while. >> >> Mark the old compat as deprecated. New SoC additions such as msm8936 and >> msm8939 should use the compat string "qcom,apq8016-lpass-cpu". >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- >> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 13 ++++++++----- >> 1 file changed, 8 insertions(+), 5 deletions(-) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml:23:9: [warning] wrong indentation: expected 10 but found 8 (indentation) > > dtschema/dtc warnings/errors: > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Bah, you were right. I didn't see this in the noise generated by the tool /home/deckard/Development/qualcomm/qlt-kernel/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml:23:9: [warning] wrong indentation: expected 10 but found 8 (indentation) Is there some way to slim the output down to just the yaml file I am interested in ? Dmitry submitted a patch for this at some stage I think
On 10/09/2022 19:22, Bryan O'Donoghue wrote: > Bah, you were right. > > I didn't see this in the noise generated by the tool > > /home/deckard/Development/qualcomm/qlt-kernel/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml:23:9: > [warning] wrong indentation: expected 10 but found 8 (indentation) > > Is there some way to slim the output down to just the yaml file I am > interested in ? > > Dmitry submitted a patch for this at some stage I think It's since long time and documented in writing-schema. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml index ef18a572a1ff3..e2c0f573a3084 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml @@ -18,11 +18,14 @@ description: | properties: compatible: - enum: - - qcom,lpass-cpu - - qcom,apq8016-lpass-cpu - - qcom,sc7180-lpass-cpu - - qcom,sc7280-lpass-cpu + oneOf: + - enum: + - qcom,lpass-cpu + - qcom,apq8016-lpass-cpu + - qcom,sc7180-lpass-cpu + - qcom,sc7280-lpass-cpu + - const: qcom,lpass-cpu-apq8016 + deprecated: true reg: minItems: 1
We've had some discongruity in the compatible string of the lpass for 8916 for a while. Mark the old compat as deprecated. New SoC additions such as msm8936 and msm8939 should use the compat string "qcom,apq8016-lpass-cpu". Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)