| Message ID | 20220917144436.7802-1-me@dylanvanassche.be (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | sound: soc: codecs: wcd-mbhc-v2: expose ALSA control for jack | expand |
On 17/09/2022 15:44, Dylan Van Assche wrote: > Jack detection is currently fully functional via the input > interface together with multimedia buttons, but is not exposed > as an ALSA control. Therefore, ALSA clients such as PulseAudio > do not pick up the jack detection events as they only support > one of the possible interface (ALSA control or input interface, > but not both). Expose the jack events as an ALSA control and input > interface to provide ALSA clients both interfaces. > > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> Reviewed-by: Caleb Connolly <caleb@connolly.tech> > --- > sound/soc/codecs/wcd-mbhc-v2.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sound/soc/codecs/wcd-mbhc-v2.c b/sound/soc/codecs/wcd-mbhc-v2.c > index 98baef594bf3..e741b522cf10 100644 > --- a/sound/soc/codecs/wcd-mbhc-v2.c > +++ b/sound/soc/codecs/wcd-mbhc-v2.c > @@ -724,6 +724,10 @@ static int wcd_mbhc_initialise(struct wcd_mbhc *mbhc) > > mutex_lock(&mbhc->lock); > > + ret = snd_jack_add_new_kctl (mbhc->jack->jack, "Headset Jack", WCD_MBHC_JACK_MASK); > + if (ret) > + dev_warn(component->dev, "failed creating Headset Jack kctl with err: %d\n", ret); > + > /* enable HS detection */ > if (mbhc->mbhc_cb->hph_pull_up_control_v2) > mbhc->mbhc_cb->hph_pull_up_control_v2(component, > -- > 2.37.3 >
diff --git a/sound/soc/codecs/wcd-mbhc-v2.c b/sound/soc/codecs/wcd-mbhc-v2.c index 98baef594bf3..e741b522cf10 100644 --- a/sound/soc/codecs/wcd-mbhc-v2.c +++ b/sound/soc/codecs/wcd-mbhc-v2.c @@ -724,6 +724,10 @@ static int wcd_mbhc_initialise(struct wcd_mbhc *mbhc) mutex_lock(&mbhc->lock); + ret = snd_jack_add_new_kctl (mbhc->jack->jack, "Headset Jack", WCD_MBHC_JACK_MASK); + if (ret) + dev_warn(component->dev, "failed creating Headset Jack kctl with err: %d\n", ret); + /* enable HS detection */ if (mbhc->mbhc_cb->hph_pull_up_control_v2) mbhc->mbhc_cb->hph_pull_up_control_v2(component,
Jack detection is currently fully functional via the input interface together with multimedia buttons, but is not exposed as an ALSA control. Therefore, ALSA clients such as PulseAudio do not pick up the jack detection events as they only support one of the possible interface (ALSA control or input interface, but not both). Expose the jack events as an ALSA control and input interface to provide ALSA clients both interfaces. Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> --- sound/soc/codecs/wcd-mbhc-v2.c | 4 ++++ 1 file changed, 4 insertions(+)