| Message ID | 20220920120802.14321-4-quic_ppareek@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: add dts for sa8540p-ride board | expand |
On 20/09/2022 14:08, Parikshit Pareek wrote: > Create new dts file specific for Qdrive board based on sa8540p chipset. > Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and > Qdrive board. > > This is quite similar to sa8295 ADP development board. Main differences > are related to connectors, and interface cards, like USB external ports, > ethernet-switch, and PCIe switch etc. > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > Reported-by: Shazad Hussain <quic_shazhuss@quicinc.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Sep 20, 2022 at 05:38:02PM +0530, Parikshit Pareek wrote: > Create new dts file specific for Qdrive board based on sa8540p chipset. > Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and > Qdrive board. > > This is quite similar to sa8295 ADP development board. Main differences > are related to connectors, and interface cards, like USB external ports, > ethernet-switch, and PCIe switch etc. > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > Reported-by: Shazad Hussain <quic_shazhuss@quicinc.com> > --- > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts > new file mode 100644 > index 000000000000..bd79866b80e1 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts > @@ -0,0 +1,31 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2021, The Linux Foundation. All rights reserved. > + * Copyright (c) 2022, Linaro Limited > + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include "sa8540p-adp.dtsi" > + > +/ { > + model = "Qualcomm SA8540 ADP"; > + compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p"; > +}; > + > +&ufs_card_hc { > + status = "disabled"; > +}; What about the UFS phy, etc? This opt-out scheme seems quite fragile. > +&usb_1 { > + status = "disabled"; > +}; > + > +&usb_1_hsphy { > + status = "disabled"; > +}; > + > +&usb_1_qmpphy { > + status = "disabled"; > +}; Johan
On Wed, Sep 21, 2022 at 08:51:32AM +0200, Johan Hovold wrote: > On Tue, Sep 20, 2022 at 05:38:02PM +0530, Parikshit Pareek wrote: > > Create new dts file specific for Qdrive board based on sa8540p chipset. > > Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and > > Qdrive board. > > > > This is quite similar to sa8295 ADP development board. Main differences > > are related to connectors, and interface cards, like USB external ports, > > ethernet-switch, and PCIe switch etc. > > > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > > Reported-by: Shazad Hussain <quic_shazhuss@quicinc.com> > > --- > > > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts > > new file mode 100644 > > index 000000000000..bd79866b80e1 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts > > @@ -0,0 +1,31 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2021, The Linux Foundation. All rights reserved. > > + * Copyright (c) 2022, Linaro Limited > > + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved. > > + */ > > + > > +/dts-v1/; > > + > > +#include "sa8540p-adp.dtsi" > > + > > +/ { > > + model = "Qualcomm SA8540 ADP"; > > + compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p"; > > +}; > > + > > +&ufs_card_hc { > > + status = "disabled"; > > +}; > > What about the UFS phy, etc? Really missed that. Will add phy nodes too. > > This opt-out scheme seems quite fragile. > > > +&usb_1 { > > + status = "disabled"; > > +}; > > + > > +&usb_1_hsphy { > > + status = "disabled"; > > +}; > > + > > +&usb_1_qmpphy { > > + status = "disabled"; > > +}; > > Johan Regards, Parikshit Pareek
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 68a172c4c748..e30d2a958937 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -54,6 +54,7 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb dtb-$(CONFIG_ARCH_QCOM) += sa8295p-adp.dtb +dtb-$(CONFIG_ARCH_QCOM) += sa8540p-adp-ride.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1-lte.dtb diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts new file mode 100644 index 000000000000..bd79866b80e1 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts @@ -0,0 +1,31 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2021, The Linux Foundation. All rights reserved. + * Copyright (c) 2022, Linaro Limited + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved. + */ + +/dts-v1/; + +#include "sa8540p-adp.dtsi" + +/ { + model = "Qualcomm SA8540 ADP"; + compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p"; +}; + +&ufs_card_hc { + status = "disabled"; +}; + +&usb_1 { + status = "disabled"; +}; + +&usb_1_hsphy { + status = "disabled"; +}; + +&usb_1_qmpphy { + status = "disabled"; +};
Create new dts file specific for Qdrive board based on sa8540p chipset. Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and Qdrive board. This is quite similar to sa8295 ADP development board. Main differences are related to connectors, and interface cards, like USB external ports, ethernet-switch, and PCIe switch etc. Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> Reported-by: Shazad Hussain <quic_shazhuss@quicinc.com> --- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts | 31 +++++++++++++++++++ 2 files changed, 32 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts