| Message ID | 20220923174224.v3.1.Ide53082044aac56877c4ff5725777769e377476a@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add LTE SKU for sc7280-evoker family | expand |
On 23/09/2022 11:42, Sheng-Liang Pan wrote: > evoker will have WIFI/LTE SKU, separete it for each different setting. > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- > > Changes in v3: > - none Don't sent the same version. Either fix what I asked for or keep discussing the topic. Ignoring comments will not get the patch merged. Best regards, Krzysztof
Hi, On Fri, Sep 23, 2022 at 5:15 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 23/09/2022 11:42, Sheng-Liang Pan wrote: > > evoker will have WIFI/LTE SKU, separete it for each different setting. > > > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > > --- > > > > Changes in v3: > > - none > > Don't sent the same version. Either fix what I asked for or keep > discussing the topic. > > Ignoring comments will not get the patch merged. I agree with Krzysztof here. I can't see any difference between v2 and v3, so I assume that you meant to fix his comment (spell "separete" correctly in the commit message _and_ ${SUBJECT}) but somehow did something wrong when sending v3. In any case, other than the typo this looks fine to me. Feel free to add my Reviewed-by when the typo is fixed. -Doug
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index b6257683a700c..065d9cc4421e0 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -575,6 +575,11 @@ properties: - const: google,evoker - const: qcom,sc7280 + - description: Google Evoker with LTE (newest rev) + items: + - const: google,evoker-sku512 + - const: qcom,sc7280 + - description: Google Herobrine (newest rev) items: - const: google,herobrine
evoker will have WIFI/LTE SKU, separete it for each different setting. Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> --- Changes in v3: - none Changes in v2: - none Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++ 1 file changed, 5 insertions(+)