| Message ID | 20220924085129.161086-2-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/msm/dsi: Add support for DSI PHY on QCM2290 | expand |
On 24/09/2022 10:51, Dmitry Baryshkov wrote: > From: Loic Poulain <loic.poulain@linaro.org> > > QCM2290 platform uses the 14nm DSI PHY driver. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > [DB: changed compat to follow the agreed scheme] Bjorn asked to keep consistency in other case: https://lore.kernel.org/all/20220829210408.gxbv6szxfwiiwrbv@builder.lan/ > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > index bc3d0b4063c7..088a03ed5f80 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > @@ -17,6 +17,7 @@ properties: > - qcom,dsi-phy-14nm > - qcom,dsi-phy-14nm-660 > - qcom,dsi-phy-14nm-8953 > + - qcom,qcm2290-dsi-phy-14nm Best regards, Krzysztof
On 24/09/2022 12:12, Krzysztof Kozlowski wrote: > On 24/09/2022 10:51, Dmitry Baryshkov wrote: >> From: Loic Poulain <loic.poulain@linaro.org> >> >> QCM2290 platform uses the 14nm DSI PHY driver. >> >> Signed-off-by: Loic Poulain <loic.poulain@linaro.org> >> [DB: changed compat to follow the agreed scheme] > > Bjorn asked to keep consistency in other case: > https://lore.kernel.org/all/20220829210408.gxbv6szxfwiiwrbv@builder.lan/ Ack. Should I use qcom,dsi-phy-14nm-2290 or qcom,dsi-phy-14nm-qcm2290? Note we already have "qcom,sc7280-dsi-phy-10nm". > >> --- >> Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> index bc3d0b4063c7..088a03ed5f80 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> @@ -17,6 +17,7 @@ properties: >> - qcom,dsi-phy-14nm >> - qcom,dsi-phy-14nm-660 >> - qcom,dsi-phy-14nm-8953 >> + - qcom,qcm2290-dsi-phy-14nm > Best regards, > Krzysztof >
On 24/09/2022 11:15, Dmitry Baryshkov wrote: > On 24/09/2022 12:12, Krzysztof Kozlowski wrote: >> On 24/09/2022 10:51, Dmitry Baryshkov wrote: >>> From: Loic Poulain <loic.poulain@linaro.org> >>> >>> QCM2290 platform uses the 14nm DSI PHY driver. >>> >>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org> >>> [DB: changed compat to follow the agreed scheme] >> >> Bjorn asked to keep consistency in other case: >> https://lore.kernel.org/all/20220829210408.gxbv6szxfwiiwrbv@builder.lan/ > > Ack. Should I use qcom,dsi-phy-14nm-2290 or qcom,dsi-phy-14nm-qcm2290? Ugh, no clue, but existing pattern would indicate without qcm. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml index bc3d0b4063c7..088a03ed5f80 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml @@ -17,6 +17,7 @@ properties: - qcom,dsi-phy-14nm - qcom,dsi-phy-14nm-660 - qcom,dsi-phy-14nm-8953 + - qcom,qcm2290-dsi-phy-14nm reg: items: