| Message ID | 20220928152822.30687-4-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: qcom-qmp: more fixes and cleanups | expand |
On 28/09/2022 17:28, Johan Hovold wrote: > Drop the common-block register defines that are unused since the QMP > driver split. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 9 --------- > 1 file changed, 9 deletions(-) > <snip> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 28 September 2022 18:28:12 GMT+03:00, Johan Hovold <johan+linaro@kernel.org> wrote: >Drop the common-block register defines that are unused since the QMP >driver split. I'd mention that they were only used for msm8996 pcie phy. Nevertheless: Reviewed-by: Dmitry Baryshkov<dmitry.baryshkov@linaro.org> > >Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >--- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 9 --------- > 1 file changed, 9 deletions(-) >
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c index abf1cf1abf2c..ec453f908f1d 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -77,11 +77,6 @@ struct qmp_phy_init_tbl { /* set of registers with offsets different per-PHY */ enum qphy_reg_layout { - /* Common block control registers */ - QPHY_COM_SW_RESET, - QPHY_COM_POWER_DOWN_CONTROL, - QPHY_COM_START_CONTROL, - QPHY_COM_PCS_READY_STATUS, /* PCS registers */ QPHY_SW_RESET, QPHY_START_CTRL, @@ -99,10 +94,6 @@ static const unsigned int ipq_pciephy_gen3_regs_layout[QPHY_LAYOUT_SIZE] = { }; static const unsigned int pciephy_regs_layout[QPHY_LAYOUT_SIZE] = { - [QPHY_COM_SW_RESET] = 0x400, - [QPHY_COM_POWER_DOWN_CONTROL] = 0x404, - [QPHY_COM_START_CONTROL] = 0x408, - [QPHY_COM_PCS_READY_STATUS] = 0x448, [QPHY_SW_RESET] = 0x00, [QPHY_START_CTRL] = 0x08, [QPHY_PCS_STATUS] = 0x174,
Drop the common-block register defines that are unused since the QMP driver split. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 9 --------- 1 file changed, 9 deletions(-)