| Message ID | 20220930192039.240486-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength | expand |
On 30.09.2022 21:20, Krzysztof Kozlowski wrote: > The pin configuration (done with generic pin controller helpers and > as expressed by bindings) requires children nodes with either: > 1. "pins" property and the actual configuration, > 2. another set of nodes with above point. > > The qup_i2c12_default pin configuration used second method - with a > "pinmux" child. > > Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630") > Cc: <stable@vger.kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > index be59a8ba9c1f..74f43da51fa5 100644 > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -487,8 +487,10 @@ pinconf { > }; > > &qup_i2c12_default { > - drive-strength = <2>; > - bias-disable; > + pinmux { > + drive-strength = <2>; > + bias-disable; > + }; > }; > > &qup_uart6_default {
On 9/30/22 2:20 PM, Krzysztof Kozlowski wrote: > The pin configuration (done with generic pin controller helpers and > as expressed by bindings) requires children nodes with either: > 1. "pins" property and the actual configuration, > 2. another set of nodes with above point. > > The qup_i2c12_default pin configuration used second method - with a > "pinmux" child. > > Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630") > Cc: <stable@vger.kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > index be59a8ba9c1f..74f43da51fa5 100644 > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -487,8 +487,10 @@ pinconf { > }; > > &qup_i2c12_default { > - drive-strength = <2>; > - bias-disable; > + pinmux { > + drive-strength = <2>; > + bias-disable; > + }; > }; > > &qup_uart6_default { Tested-by: Steev Klimaszewski <steev@kali.org>
On Fri, 30 Sep 2022 21:20:37 +0200, Krzysztof Kozlowski wrote: > The pin configuration (done with generic pin controller helpers and > as expressed by bindings) requires children nodes with either: > 1. "pins" property and the actual configuration, > 2. another set of nodes with above point. > > The qup_i2c12_default pin configuration used second method - with a > "pinmux" child. > > [...] Applied, thanks! [1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength commit: fd49776d8f458bba5499384131eddc0b8bcaf50c [2/3] arm64: dts: qcom: sdm850-samsung-w737: correct I2C12 pins drive strength commit: 3638ea010c37e1e6d93474c4b3368f403600413f [3/3] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name commit: 58c4a0b6f4bdf8c3c2b4aad7f980e4019cc0fc83 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts index be59a8ba9c1f..74f43da51fa5 100644 --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts @@ -487,8 +487,10 @@ pinconf { }; &qup_i2c12_default { - drive-strength = <2>; - bias-disable; + pinmux { + drive-strength = <2>; + bias-disable; + }; }; &qup_uart6_default {
The pin configuration (done with generic pin controller helpers and as expressed by bindings) requires children nodes with either: 1. "pins" property and the actual configuration, 2. another set of nodes with above point. The qup_i2c12_default pin configuration used second method - with a "pinmux" child. Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630") Cc: <stable@vger.kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)