| Message ID | 20221003182637.v6.3.I50d04dcbe735dda69995cf1078824d671501869e@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add LTE SKU for sc7280-evoker family | expand |
Hi, On Mon, Oct 3, 2022 at 3:28 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > Change touchpad and touchscreen node for evoker > Touchpad: SA461D-1011 > Touchscreen: GT7986U > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- > > Changes in v6: > - add removed pinctrl and align touchscreen label with herobrine board > > Changes in v5: > - Touchscreen / trackpad patch new for v5 > > .../boot/dts/qcom/sc7280-herobrine-evoker.dtsi | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi > index e78072159d54b..d1723fbffae67 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi > @@ -23,16 +23,15 @@ ap_tp_i2c: &i2c0 { > status = "okay"; > clock-frequency = <400000>; > > - trackpad: trackpad@2c { > - compatible = "hid-over-i2c"; > - reg = <0x2c>; > + trackpad: trackpad@15 { > + compatible = "elan,ekth3000"; > + reg = <0x15>; > pinctrl-names = "default"; > pinctrl-0 = <&tp_int_odl>; > > interrupt-parent = <&tlmm>; > interrupts = <7 IRQ_TYPE_EDGE_FALLING>; > > - hid-descr-addr = <0x20>; > vcc-supply = <&pp3300_z1>; > > wakeup-source; > @@ -43,9 +42,9 @@ ts_i2c: &i2c13 { > status = "okay"; > clock-frequency = <400000>; > > - ap_ts: touchscreen@10 { > - compatible = "elan,ekth6915"; > - reg = <0x10>; > + ap_ts: touchscreen@5d { > + compatible = "goodix,gt7375p"; > + reg = <0x5d>; You silently ignored my feedback here: [1] https://lore.kernel.org/r/CAD=FV=XHr9Y6oQR19wVVHC6jzcd82hf1bHNbr62n89vuTbme9Q@mail.gmail.com Did you not see it? Did you ignore it for a reason? -Doug
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi index e78072159d54b..d1723fbffae67 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi @@ -23,16 +23,15 @@ ap_tp_i2c: &i2c0 { status = "okay"; clock-frequency = <400000>; - trackpad: trackpad@2c { - compatible = "hid-over-i2c"; - reg = <0x2c>; + trackpad: trackpad@15 { + compatible = "elan,ekth3000"; + reg = <0x15>; pinctrl-names = "default"; pinctrl-0 = <&tp_int_odl>; interrupt-parent = <&tlmm>; interrupts = <7 IRQ_TYPE_EDGE_FALLING>; - hid-descr-addr = <0x20>; vcc-supply = <&pp3300_z1>; wakeup-source; @@ -43,9 +42,9 @@ ts_i2c: &i2c13 { status = "okay"; clock-frequency = <400000>; - ap_ts: touchscreen@10 { - compatible = "elan,ekth6915"; - reg = <0x10>; + ap_ts: touchscreen@5d { + compatible = "goodix,gt7375p"; + reg = <0x5d>; pinctrl-names = "default"; pinctrl-0 = <&ts_int_conn>, <&ts_rst_conn>; @@ -54,7 +53,7 @@ ap_ts: touchscreen@10 { reset-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>; - vcc33-supply = <&ts_avdd>; + vdd-supply = <&ts_avdd>; }; };
Change touchpad and touchscreen node for evoker Touchpad: SA461D-1011 Touchscreen: GT7986U Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> --- Changes in v6: - add removed pinctrl and align touchscreen label with herobrine board Changes in v5: - Touchscreen / trackpad patch new for v5 .../boot/dts/qcom/sc7280-herobrine-evoker.dtsi | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)