diff mbox series

[v3,2/2] dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip

Message ID 20221003185500.928608-3-dsankouski@gmail.com (mailing list archive)
State Superseded
Headers show
Series add device Xiaomi Mi 6 (codename sagit) and board binding | expand

Commit Message

Dzmitry Sankouski Oct. 3, 2022, 6:55 p.m. UTC
add xiaomi,sagit board (Xiaomi Mi 6) binding

Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes for v3:
- remove unused 'sagit' compatible line

 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Konrad Dybcio Oct. 3, 2022, 9:12 p.m. UTC | #1
On 03/10/2022 20:55, Dzmitry Sankouski wrote:
> add xiaomi,sagit board (Xiaomi Mi 6) binding
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---

Binding changes should generally go before the actual patch, so that

there's no commit where there's an undocumented compatible.

Konrad

> Changes for v3:
> - remove unused 'sagit' compatible line
>
>   Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index fb1d00bcc847..294075bafb97 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -239,6 +239,7 @@ properties:
>                 - sony,xperia-lilac
>                 - sony,xperia-maple
>                 - sony,xperia-poplar
> +              - xiaomi,sagit
>             - const: qcom,msm8998
>   
>         - items:
Krzysztof Kozlowski Oct. 4, 2022, 7:05 a.m. UTC | #2
On 03/10/2022 20:55, Dzmitry Sankouski wrote:
> add xiaomi,sagit board (Xiaomi Mi 6) binding

Start with capital letter and finish with full-stop.

> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Changes for v3:
> - remove unused 'sagit' compatible line

With commit fixes:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index fb1d00bcc847..294075bafb97 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -239,6 +239,7 @@  properties:
               - sony,xperia-lilac
               - sony,xperia-maple
               - sony,xperia-poplar
+              - xiaomi,sagit
           - const: qcom,msm8998
 
       - items: