| Message ID | 20221010024010.2873633-1-chenzhongjin@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [-next] drm/msm: Remove unused variables 'top' | expand |
On 10/9/2022 7:40 PM, Chen Zhongjin wrote: > 'commit 1e5df24b996c ("drm/msm/dpu: drop length from struct dpu_hw_blk_reg_map")' > 'commit 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct dpu_hw_blk_reg_map")' > These commits had merged hw.blk_off and hw.blk_off to mdp. > So we don't need to get dpu_hw_mdp in dpu_kms_mdp_snapshot() now. > > Since there is no code using 'top' in this function. Remove it. > > Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com> This has already been fixed with: https://gitlab.freedesktop.org/drm/msm/-/commit/4bca876458caf7c105ab2ae9d80ff2cc9c60388d > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 008e1420e6e5..79e81f1443be 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -902,13 +902,9 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k > int i; > struct dpu_kms *dpu_kms; > const struct dpu_mdss_cfg *cat; > - struct dpu_hw_mdp *top; > > dpu_kms = to_dpu_kms(kms); > - > cat = dpu_kms->catalog; > - top = dpu_kms->hw_mdp; > - > pm_runtime_get_sync(&dpu_kms->pdev->dev); > > /* dump CTL sub-blocks HW regs info */
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index 008e1420e6e5..79e81f1443be 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -902,13 +902,9 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k int i; struct dpu_kms *dpu_kms; const struct dpu_mdss_cfg *cat; - struct dpu_hw_mdp *top; dpu_kms = to_dpu_kms(kms); - cat = dpu_kms->catalog; - top = dpu_kms->hw_mdp; - pm_runtime_get_sync(&dpu_kms->pdev->dev); /* dump CTL sub-blocks HW regs info */
'commit 1e5df24b996c ("drm/msm/dpu: drop length from struct dpu_hw_blk_reg_map")' 'commit 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct dpu_hw_blk_reg_map")' These commits had merged hw.blk_off and hw.blk_off to mdp. So we don't need to get dpu_hw_mdp in dpu_kms_mdp_snapshot() now. Since there is no code using 'top' in this function. Remove it. Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ---- 1 file changed, 4 deletions(-)