diff mbox series

dt-bindings: interconnect: qcom,msm8998-bwmon: Correct SC7280 CPU compatible

Message ID 20221011140744.29829-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State Not Applicable
Headers show
Series dt-bindings: interconnect: qcom,msm8998-bwmon: Correct SC7280 CPU compatible | expand

Commit Message

Krzysztof Kozlowski Oct. 11, 2022, 2:07 p.m. UTC
Two different compatibles for SC7280 CPU BWMON instance were used
in DTS and bindings.  Correct the bindings to use the same one as in
DTS, because it is more specific.

Fixes: b7c84ae757c2 ("dt-bindings: interconnect: qcom,msm8998-bwmon: Add support for sc7280 BWMONs")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rajendra Nayak Oct. 12, 2022, 6:08 a.m. UTC | #1
On 10/11/2022 7:37 PM, Krzysztof Kozlowski wrote:
> Two different compatibles for SC7280 CPU BWMON instance were used
> in DTS and bindings.  Correct the bindings to use the same one as in
> DTS, because it is more specific.
> 
> Fixes: b7c84ae757c2 ("dt-bindings: interconnect: qcom,msm8998-bwmon: Add support for sc7280 BWMONs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

ah, thanks for the fixing this,
Reviewed-by: Rajendra Nayak <quic_rjendra@quicinc.com>

> ---
>   .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> index 2684562df4d9..be29e0b80995 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> @@ -24,7 +24,7 @@ properties:
>       oneOf:
>         - items:
>             - enum:
> -              - qcom,sc7280-bwmon
> +              - qcom,sc7280-cpu-bwmon
>                 - qcom,sdm845-bwmon
>             - const: qcom,msm8998-bwmon
>         - const: qcom,msm8998-bwmon       # BWMON v4
Rob Herring (Arm) Oct. 12, 2022, 4:11 p.m. UTC | #2
On Tue, 11 Oct 2022 10:07:44 -0400, Krzysztof Kozlowski wrote:
> Two different compatibles for SC7280 CPU BWMON instance were used
> in DTS and bindings.  Correct the bindings to use the same one as in
> DTS, because it is more specific.
> 
> Fixes: b7c84ae757c2 ("dt-bindings: interconnect: qcom,msm8998-bwmon: Add support for sc7280 BWMONs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Georgi Djakov Oct. 28, 2022, 7:14 a.m. UTC | #3
On 11.10.22 17:07, Krzysztof Kozlowski wrote:
> Two different compatibles for SC7280 CPU BWMON instance were used
> in DTS and bindings.  Correct the bindings to use the same one as in
> DTS, because it is more specific.
> 
> Fixes: b7c84ae757c2 ("dt-bindings: interconnect: qcom,msm8998-bwmon: Add support for sc7280 BWMONs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

I assume that this will be picked by Bjorn. Please let me know otherwise.

Acked-by: Georgi Djakov <djakov@kernel.org>

> ---
>   .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> index 2684562df4d9..be29e0b80995 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> @@ -24,7 +24,7 @@ properties:
>       oneOf:
>         - items:
>             - enum:
> -              - qcom,sc7280-bwmon
> +              - qcom,sc7280-cpu-bwmon
>                 - qcom,sdm845-bwmon
>             - const: qcom,msm8998-bwmon
>         - const: qcom,msm8998-bwmon       # BWMON v4
Krzysztof Kozlowski Oct. 28, 2022, 11:24 a.m. UTC | #4
On 28/10/2022 03:14, Georgi Djakov wrote:
> On 11.10.22 17:07, Krzysztof Kozlowski wrote:
>> Two different compatibles for SC7280 CPU BWMON instance were used
>> in DTS and bindings.  Correct the bindings to use the same one as in
>> DTS, because it is more specific.
>>
>> Fixes: b7c84ae757c2 ("dt-bindings: interconnect: qcom,msm8998-bwmon: Add support for sc7280 BWMONs")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> I assume that this will be picked by Bjorn. Please let me know otherwise.
> 

Bjorn marked it as not applicable, so please pick it up for interconnect.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
index 2684562df4d9..be29e0b80995 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
@@ -24,7 +24,7 @@  properties:
     oneOf:
       - items:
           - enum:
-              - qcom,sc7280-bwmon
+              - qcom,sc7280-cpu-bwmon
               - qcom,sdm845-bwmon
           - const: qcom,msm8998-bwmon
       - const: qcom,msm8998-bwmon       # BWMON v4