| Message ID | 20221103-upstream-goodix-reset-v3-9-0975809eb183@theobroma-systems.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | fix reset line polarity for Goodix touchscreen controllers | expand |
Hi Quentin, On 12/5/22 14:40, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > The reset line is active low for the Goodix touchscreen controller so > let's fix the polarity in the Device Tree node. > > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> Cannot test at the moment, but LGTM! At least as far as the RK3568 EVB1 is concerned: Acked-by: Michael Riesch <michael.riesch@wolfvision.net> Thanks and best regards, Michael > --- > arch/arm64/boot/dts/rockchip/px30-evb.dts | 2 +- > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 2 +- > arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts > index c1bbd555f5f5b..2087dc7299446 100644 > --- a/arch/arm64/boot/dts/rockchip/px30-evb.dts > +++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts > @@ -420,7 +420,7 @@ touchscreen@14 { > interrupt-parent = <&gpio0>; > interrupts = <RK_PA5 IRQ_TYPE_LEVEL_LOW>; > irq-gpios = <&gpio0 RK_PA5 GPIO_ACTIVE_LOW>; > - reset-gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_LOW>; > VDDIO-supply = <&vcc3v3_lcd>; > }; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > index 78157521e9449..e63491fb443be 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > @@ -588,7 +588,7 @@ touch: touchscreen@5d { > AVDD28-supply = <&vcc3v0_touch>; > VDDIO-supply = <&vcc3v0_touch>; > irq-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>; > - reset-gpios = <&gpio4 RK_PD6 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio4 RK_PD6 GPIO_ACTIVE_LOW>; > status = "disabled"; > }; > }; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > index 674792567fa6e..234531aaa430a 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > @@ -495,7 +495,7 @@ touchscreen0: goodix@14 { > irq-gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>; > pinctrl-names = "default"; > pinctrl-0 = <&touch_int &touch_rst>; > - reset-gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_LOW>; > VDDIO-supply = <&vcc3v3_lcd0_n>; > }; > }; >
diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts index c1bbd555f5f5b..2087dc7299446 100644 --- a/arch/arm64/boot/dts/rockchip/px30-evb.dts +++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts @@ -420,7 +420,7 @@ touchscreen@14 { interrupt-parent = <&gpio0>; interrupts = <RK_PA5 IRQ_TYPE_LEVEL_LOW>; irq-gpios = <&gpio0 RK_PA5 GPIO_ACTIVE_LOW>; - reset-gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_LOW>; VDDIO-supply = <&vcc3v3_lcd>; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi index 78157521e9449..e63491fb443be 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi @@ -588,7 +588,7 @@ touch: touchscreen@5d { AVDD28-supply = <&vcc3v0_touch>; VDDIO-supply = <&vcc3v0_touch>; irq-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>; - reset-gpios = <&gpio4 RK_PD6 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio4 RK_PD6 GPIO_ACTIVE_LOW>; status = "disabled"; }; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts index 674792567fa6e..234531aaa430a 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts @@ -495,7 +495,7 @@ touchscreen0: goodix@14 { irq-gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; pinctrl-0 = <&touch_int &touch_rst>; - reset-gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_LOW>; VDDIO-supply = <&vcc3v3_lcd0_n>; }; };