diff mbox series

[1/2] dt-bindings: soc: qcom: Add bindings for Qualcomm Ramp Controller

Message ID 20221104133506.131316-2-angelogioacchino.delregno@collabora.com (mailing list archive)
State Superseded
Headers show
Series Qualcomm Ramp Controller and MSM8976 config | expand

Commit Message

AngeloGioacchino Del Regno Nov. 4, 2022, 1:35 p.m. UTC 
Document bindings for the Qualcomm Ramp Controller, found on various
legacy Qualcomm SoCs.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../soc/qcom/qcom,ramp-controller.yaml        | 42 +++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml

Comments

Krzysztof Kozlowski Nov. 4, 2022, 2 p.m. UTC | #1 
On 04/11/2022 09:35, AngeloGioacchino Del Regno wrote:
> Document bindings for the Qualcomm Ramp Controller, found on various
> legacy Qualcomm SoCs.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../soc/qcom/qcom,ramp-controller.yaml        | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml

Filename based on compatible, so qcom,msm8976-ramp-controller.yaml

> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml
> new file mode 100644
> index 000000000000..95ce48cfca4e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/qcom/qcom,ramp-controller.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

Drop quotes from both lines above.

> +
> +title: Qualcomm Ramp Controller
> +
> +maintainers:
> +  - AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> +
> +description:
> +  The Ramp Controller is used to program the sequence ID for pulse
> +  swallowing, enable sequences and linking Sequence IDs (SIDs) for

s/linking/link/ if I understand the sentence correctly (is used to:
program, enable and link)

> +  the CPU cores on some Qualcomm SoCs.
> +
> +properties:
> +  compatible:
> +    items:

Drop items.

> +      enum:

I also think you did not test it...

> +        - qcom,msm8976-ramp-controller
> +
> +  reg:
> +    maxItems: 1
> +

Best regards,
Krzysztof
AngeloGioacchino Del Regno Nov. 4, 2022, 2:12 p.m. UTC | #2 
Il 04/11/22 15:00, Krzysztof Kozlowski ha scritto:
> On 04/11/2022 09:35, AngeloGioacchino Del Regno wrote:
>> Document bindings for the Qualcomm Ramp Controller, found on various
>> legacy Qualcomm SoCs.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   .../soc/qcom/qcom,ramp-controller.yaml        | 42 +++++++++++++++++++
>>   1 file changed, 42 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml
> 
> Filename based on compatible, so qcom,msm8976-ramp-controller.yaml
> 
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml
>> new file mode 100644
>> index 000000000000..95ce48cfca4e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml
>> @@ -0,0 +1,42 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/soc/qcom/qcom,ramp-controller.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> 
> Drop quotes from both lines above.
> 
>> +
>> +title: Qualcomm Ramp Controller
>> +
>> +maintainers:
>> +  - AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> +
>> +description:
>> +  The Ramp Controller is used to program the sequence ID for pulse
>> +  swallowing, enable sequences and linking Sequence IDs (SIDs) for
> 
> s/linking/link/ if I understand the sentence correctly (is used to:
> program, enable and link)
> 
>> +  the CPU cores on some Qualcomm SoCs.
>> +
>> +properties:
>> +  compatible:
>> +    items:
> 
> Drop items.
> 
>> +      enum:
> 
> I also think you did not test it...

I'm sorry, I acknowledged that I didn't test the yaml only after sending it...
v2 is coming :-)

Thanks,
Angelo
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml
new file mode 100644
index 000000000000..95ce48cfca4e
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml
@@ -0,0 +1,42 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,ramp-controller.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Ramp Controller
+
+maintainers:
+  - AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
+
+description:
+  The Ramp Controller is used to program the sequence ID for pulse
+  swallowing, enable sequences and linking Sequence IDs (SIDs) for
+  the CPU cores on some Qualcomm SoCs.
+
+properties:
+  compatible:
+    items:
+      enum:
+        - qcom,msm8976-ramp-controller
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        power-controller@b014000 {
+            compatible = "qcom,msm8976-ramp-controller";
+            reg = <0x0b014000 0x68>;
+        };
+    };