diff mbox series

[v2,8/8] dt-bindings: iommu: qcom,iommu: Document MSM8976 compatible

Message ID 20221111145919.221159-9-angelogioacchino.delregno@collabora.com (mailing list archive)
State Superseded
Headers show
Series Add support for Qualcomm's legacy IOMMU v2 | expand

Commit Message

AngeloGioacchino Del Regno Nov. 11, 2022, 2:59 p.m. UTC
Add "qcom,msm8976-iommu" to support IOMMUs on this SoC.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 Documentation/devicetree/bindings/iommu/qcom,iommu.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Nov. 14, 2022, 8:22 a.m. UTC | #1
On 11/11/2022 15:59, AngeloGioacchino Del Regno wrote:
> Add "qcom,msm8976-iommu" to support IOMMUs on this SoC.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  Documentation/devicetree/bindings/iommu/qcom,iommu.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/qcom,iommu.txt b/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
> index b762772f80e7..b7a5822ac00d 100644
> --- a/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
> +++ b/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
> @@ -9,7 +9,8 @@ to non-secure vs secure interrupt line.
>  
>  - compatible       : Should be one of:
>  
> -                        "qcom,msm8916-iommu"
> +                        - "qcom,msm8916-iommu"
> +                        - "qcom,msm8976-iommu"

Shouldn't the new compatible be followed by IOMMU v2, not v1?

Best regards,
Krzysztof
AngeloGioacchino Del Regno Nov. 15, 2022, 9:52 a.m. UTC | #2
Il 14/11/22 09:22, Krzysztof Kozlowski ha scritto:
> On 11/11/2022 15:59, AngeloGioacchino Del Regno wrote:
>> Add "qcom,msm8976-iommu" to support IOMMUs on this SoC.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   Documentation/devicetree/bindings/iommu/qcom,iommu.txt | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iommu/qcom,iommu.txt b/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
>> index b762772f80e7..b7a5822ac00d 100644
>> --- a/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
>> +++ b/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
>> @@ -9,7 +9,8 @@ to non-secure vs secure interrupt line.
>>   
>>   - compatible       : Should be one of:
>>   
>> -                        "qcom,msm8916-iommu"
>> +                        - "qcom,msm8916-iommu"
>> +                        - "qcom,msm8976-iommu"
> 
> Shouldn't the new compatible be followed by IOMMU v2, not v1?
> 

Yes, effectively, it should.

I'll have to partially rewrite also commit 6/8, so I'll have to drop your
Acked-by tag on both....
Will send a new one shortly.

Cheers,
Angelo
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iommu/qcom,iommu.txt b/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
index b762772f80e7..b7a5822ac00d 100644
--- a/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
+++ b/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
@@ -9,7 +9,8 @@  to non-secure vs secure interrupt line.
 
 - compatible       : Should be one of:
 
-                        "qcom,msm8916-iommu"
+                        - "qcom,msm8916-iommu"
+                        - "qcom,msm8976-iommu"
 
                      Followed by one of: