diff mbox series

dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes

Message ID 20221118182535.11156-1-quic_molvera@quicinc.com (mailing list archive)
State Superseded
Headers show
Series dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes | expand

Commit Message

Melody Olvera Nov. 18, 2022, 6:25 p.m. UTC 
Update the bindings to allow for generic regulator nodes instead of
device-specific node names.

Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
This patch comes from discussions on [1] and is separated out. It also
has updated pattern matching to match the comments left from [1].

[1] https://lore.kernel.org/all/20221026200429.162212-2-quic_molvera@quicinc.com/

 Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


base-commit: 147307c69ba4441ee90c1f8ce8edf5df4ea60f67

Comments

Krzysztof Kozlowski Nov. 21, 2022, 10:27 a.m. UTC | #1 
On 18/11/2022 19:25, Melody Olvera wrote:
> Update the bindings to allow for generic regulator nodes instead of
> device-specific node names.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 22, 2022, 11:41 a.m. UTC | #2 
On 21/11/2022 11:27, Krzysztof Kozlowski wrote:
> On 18/11/2022 19:25, Melody Olvera wrote:
>> Update the bindings to allow for generic regulator nodes instead of
>> device-specific node names.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Unreviewed, because this should include also SM8550, otherwise a new
patch will follow it immediately, which is not necessary.

On SM8550 the apps_rsc node has up to 6 PMICs, so it should be instead:
'^regulators(-[0-9])?$':

Best regards,
Krzysztof
Melody Olvera Nov. 22, 2022, 4:44 p.m. UTC | #3 
On 11/22/2022 5:41 AM, Krzysztof Kozlowski wrote:
> On 21/11/2022 11:27, Krzysztof Kozlowski wrote:
>> On 18/11/2022 19:25, Melody Olvera wrote:
>>> Update the bindings to allow for generic regulator nodes instead of
>>> device-specific node names.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>> ---
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Unreviewed, because this should include also SM8550, otherwise a new
> patch will follow it immediately, which is not necessary.
>
> On SM8550 the apps_rsc node has up to 6 PMICs, so it should be instead:
> '^regulators(-[0-9])?$':

Sure thing.

Thanks,
Melody

> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
index b246500d3d5d..23ee56bfa636 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
@@ -112,8 +112,9 @@  properties:
     $ref: /schemas/power/qcom,rpmpd.yaml#
 
 patternProperties:
-  '-regulators$':
+  '^regulators(-[01])?$':
     $ref: /schemas/regulator/qcom,rpmh-regulator.yaml#
+    unevaluatedProperties: false
 
 required:
   - compatible