| Message ID | 20221122124627.174403-1-xiujianfeng@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [-next] cpufreq: qcom-hw: Fix memory leak in qcom_cpufreq_hw_driver_probe() | expand |
On Tue, Nov 22, 2022 at 08:46:27PM +0800, Xiu Jianfeng wrote: > If devm_clk_hw_register() fails, clk_init.name should be freed before > return error, otherwise will cause memory leak issue, fix it. > > Fixes: 84063a1cbe9e ("cpufreq: qcom-hw: Add CPU clock provider support") > Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Thanks, Mani > --- > drivers/cpufreq/qcom-cpufreq-hw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c > index 1bd1e9ae5308..340fed35e45d 100644 > --- a/drivers/cpufreq/qcom-cpufreq-hw.c > +++ b/drivers/cpufreq/qcom-cpufreq-hw.c > @@ -723,6 +723,7 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev) > ret = devm_clk_hw_register(dev, &data->cpu_clk); > if (ret < 0) { > dev_err(dev, "Failed to register clock %d: %d\n", i, ret); > + kfree(clk_init.name); > return ret; > } > > -- > 2.17.1 >
On 22-11-22, 20:46, Xiu Jianfeng wrote: > If devm_clk_hw_register() fails, clk_init.name should be freed before > return error, otherwise will cause memory leak issue, fix it. > > Fixes: 84063a1cbe9e ("cpufreq: qcom-hw: Add CPU clock provider support") > Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com> > --- > drivers/cpufreq/qcom-cpufreq-hw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c > index 1bd1e9ae5308..340fed35e45d 100644 > --- a/drivers/cpufreq/qcom-cpufreq-hw.c > +++ b/drivers/cpufreq/qcom-cpufreq-hw.c > @@ -723,6 +723,7 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev) > ret = devm_clk_hw_register(dev, &data->cpu_clk); > if (ret < 0) { > dev_err(dev, "Failed to register clock %d: %d\n", i, ret); > + kfree(clk_init.name); > return ret; > } Squashed with the original commit and added your SoB. Thanks.
diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c index 1bd1e9ae5308..340fed35e45d 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -723,6 +723,7 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev) ret = devm_clk_hw_register(dev, &data->cpu_clk); if (ret < 0) { dev_err(dev, "Failed to register clock %d: %d\n", i, ret); + kfree(clk_init.name); return ret; }
If devm_clk_hw_register() fails, clk_init.name should be freed before return error, otherwise will cause memory leak issue, fix it. Fixes: 84063a1cbe9e ("cpufreq: qcom-hw: Add CPU clock provider support") Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com> --- drivers/cpufreq/qcom-cpufreq-hw.c | 1 + 1 file changed, 1 insertion(+)