| Message ID | 20221127203240.54955-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4df05b44468cdf5dea7a7aa291eeabd7e639f8ff |
| Headers | show |
| Series | [v2,1/3] arm64: dts: qcom: msm8996-xiaomi-gemini: use preferred enable-gpios for LP5562 LED | expand |
On 27.11.2022 21:32, Krzysztof Kozlowski wrote: > The preferred name suffix for properties with single and multiple GPIOs > is "gpios". Linux GPIO core code supports both. Bindings are going to > expect the "gpios" one: > > qcom/msm8996-xiaomi-gemini.dtb: lp5562@30: 'enable-gpio' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Changes since v1: > 1. New patch > --- > arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts > index d8734913482f..dbd5f7e2df65 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts > +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts > @@ -54,7 +54,7 @@ lp5562@30 { > reg = <0x30>; > #address-cells = <1>; > #size-cells = <0>; > - enable-gpio = <&pm8994_gpios 7 1>; > + enable-gpios = <&pm8994_gpios 7 1>; > clock-mode = /bits/8 <2>; > label = "button-backlight"; >
On Sun, 27 Nov 2022 21:32:38 +0100, Krzysztof Kozlowski wrote: > The preferred name suffix for properties with single and multiple GPIOs > is "gpios". Linux GPIO core code supports both. Bindings are going to > expect the "gpios" one: > > qcom/msm8996-xiaomi-gemini.dtb: lp5562@30: 'enable-gpio' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+' > > > [...] Applied, thanks! [3/3] ARM: dts: qcom: align LED node names with dtschema commit: 3ebeed30209aa50505956076aff1cf00a6381760 Best regards,
On Sun, 27 Nov 2022 21:32:38 +0100, Krzysztof Kozlowski wrote: > The preferred name suffix for properties with single and multiple GPIOs > is "gpios". Linux GPIO core code supports both. Bindings are going to > expect the "gpios" one: > > qcom/msm8996-xiaomi-gemini.dtb: lp5562@30: 'enable-gpio' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+' > > > [...] Applied, thanks! [1/3] arm64: dts: qcom: msm8996-xiaomi-gemini: use preferred enable-gpios for LP5562 LED commit: 4df05b44468cdf5dea7a7aa291eeabd7e639f8ff [2/3] arm64: dts: qcom: align LED node names with dtschema (no commit info) Best regards,
diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts index d8734913482f..dbd5f7e2df65 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts @@ -54,7 +54,7 @@ lp5562@30 { reg = <0x30>; #address-cells = <1>; #size-cells = <0>; - enable-gpio = <&pm8994_gpios 7 1>; + enable-gpios = <&pm8994_gpios 7 1>; clock-mode = /bits/8 <2>; label = "button-backlight";
The preferred name suffix for properties with single and multiple GPIOs is "gpios". Linux GPIO core code supports both. Bindings are going to expect the "gpios" one: qcom/msm8996-xiaomi-gemini.dtb: lp5562@30: 'enable-gpio' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: 1. New patch --- arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)