| Message ID | 20221204061555.1355453-4-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: add missing subdevices to qcom-pm8xxx schema | expand |
On Sun, 4 Dec 2022 08:15:54 +0200 Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > Several ADC channels are bound to the Multi Purpose Pins (MPPs). Allow > specifying such channels using the mppN device node (as used on apq8060 > dragonboard). > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> So I understand this more, why do the node names have to have anything to do with the particular pin? I'm assuming the reg value provides that relationship. > --- > Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml > index d186b713d6a7..fee30e6ddd62 100644 > --- a/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml > @@ -64,7 +64,7 @@ required: > - adc-channel@f > > patternProperties: > - "^(adc-channel@)[0-9a-f]$": > + "^(adc-channel|mpp[0-9]+)@[0-9a-f]$": > type: object > description: | > ADC channel specific configuration.
On Sun, 4 Dec 2022 at 17:24, Jonathan Cameron <jic23@kernel.org> wrote: > > On Sun, 4 Dec 2022 08:15:54 +0200 > Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > > Several ADC channels are bound to the Multi Purpose Pins (MPPs). Allow > > specifying such channels using the mppN device node (as used on apq8060 > > dragonboard). > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > So I understand this more, why do the node names have to have anything to > do with the particular pin? I'm assuming the reg value provides that > relationship. Yes, the reg provides this relationship. If I understand correctly, the dts authors (see arch/arm/boot/dts/qcom-apq8060-dragonboard.dts) wanted to point out that these channels are connected to MPP pins rather than raw adc channels (e.g. vcoin, vbat, etc). > > > --- > > Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml > > index d186b713d6a7..fee30e6ddd62 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml > > @@ -64,7 +64,7 @@ required: > > - adc-channel@f > > > > patternProperties: > > - "^(adc-channel@)[0-9a-f]$": > > + "^(adc-channel|mpp[0-9]+)@[0-9a-f]$": > > type: object > > description: | > > ADC channel specific configuration. >
diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml index d186b713d6a7..fee30e6ddd62 100644 --- a/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml @@ -64,7 +64,7 @@ required: - adc-channel@f patternProperties: - "^(adc-channel@)[0-9a-f]$": + "^(adc-channel|mpp[0-9]+)@[0-9a-f]$": type: object description: | ADC channel specific configuration.
Several ADC channels are bound to the Multi Purpose Pins (MPPs). Allow specifying such channels using the mppN device node (as used on apq8060 dragonboard). Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/iio/adc/qcom,pm8018-adc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)