| Message ID | 20221207001503.93790-3-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk: qcom: smd-rpm: drop platform names | expand |
On 07/12/2022 01:14, Dmitry Baryshkov wrote: > The commit eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm > clocks") defined the pin-controlled ln_bb_clk clocks, but didn't add > them to the qcs404_clks array. Add them to make these clocks usable to > platform devices. > Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > Fixes: eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm clocks") > Reviewed-by: Alex Elder <elder@linaro.org? Wrong character at the end. > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/clk/qcom/clk-smd-rpm.c | 2 ++ > include/dt-bindings/clock/qcom,rpmcc.h | 2 ++ > 2 files changed, 4 insertions(+) > No, bindings are separate. Best regards, Krzysztof
On Fri, 9 Dec 2022 at 18:14, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 07/12/2022 01:14, Dmitry Baryshkov wrote: > > The commit eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm > > clocks") defined the pin-controlled ln_bb_clk clocks, but didn't add > > them to the qcs404_clks array. Add them to make these clocks usable to > > platform devices. > > > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > > Fixes: eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm clocks") > > Reviewed-by: Alex Elder <elder@linaro.org? > > Wrong character at the end. > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > drivers/clk/qcom/clk-smd-rpm.c | 2 ++ > > include/dt-bindings/clock/qcom,rpmcc.h | 2 ++ > > 2 files changed, 4 insertions(+) > > > > No, bindings are separate. Argh, I didn't realise that this piece also goes into your realm. Please excuse me. I'll send v2.
On Fri, 9 Dec 2022 at 17:28, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Fri, 9 Dec 2022 at 18:14, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > > > On 07/12/2022 01:14, Dmitry Baryshkov wrote: > > > The commit eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm > > > clocks") defined the pin-controlled ln_bb_clk clocks, but didn't add > > > them to the qcs404_clks array. Add them to make these clocks usable to > > > platform devices. > > > > > > > Please use scripts/get_maintainers.pl to get a list of necessary people > > and lists to CC. It might happen, that command when run on an older > > kernel, gives you outdated entries. Therefore please be sure you base > > your patches on recent Linux kernel. > > > > > Fixes: eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm clocks") > > > Reviewed-by: Alex Elder <elder@linaro.org? > > > > Wrong character at the end. > > > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > --- > > > drivers/clk/qcom/clk-smd-rpm.c | 2 ++ > > > include/dt-bindings/clock/qcom,rpmcc.h | 2 ++ > > > 2 files changed, 4 insertions(+) > > > > > > > No, bindings are separate. > > Argh, I didn't realise that this piece also goes into your realm. > Please excuse me. That's we we have checkpatch: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst Such issues are solved with tools. You will not miss any maintainers if you automate the sending command (e.g. with identity and tocmd/cccmd). The same with mixing files - checkpatch tests for it. Best regards, Krzysztof
diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c index 4947d5eab591..ccc54913eca5 100644 --- a/drivers/clk/qcom/clk-smd-rpm.c +++ b/drivers/clk/qcom/clk-smd-rpm.c @@ -843,6 +843,8 @@ static struct clk_smd_rpm *qcs404_clks[] = { [RPM_SMD_RF_CLK1_A] = &msm8916_rf_clk1_a, [RPM_SMD_LN_BB_CLK] = &msm8992_ln_bb_clk, [RPM_SMD_LN_BB_A_CLK] = &msm8992_ln_bb_a_clk, + [RPM_SMD_LN_BB_CLK_PIN] = &qcs404_ln_bb_clk_pin, + [RPM_SMD_LN_BB_A_CLK_PIN] = &qcs404_ln_bb_clk_a_pin, }; static const struct rpm_smd_clk_desc rpm_clk_qcs404 = { diff --git a/include/dt-bindings/clock/qcom,rpmcc.h b/include/dt-bindings/clock/qcom,rpmcc.h index c0ad624e930e..46309c9953b2 100644 --- a/include/dt-bindings/clock/qcom,rpmcc.h +++ b/include/dt-bindings/clock/qcom,rpmcc.h @@ -168,5 +168,7 @@ #define RPM_SMD_MSS_CFG_AHB_CLK 122 #define RPM_SMD_MSS_CFG_AHB_A_CLK 123 #define RPM_SMD_BIMC_FREQ_LOG 124 +#define RPM_SMD_LN_BB_CLK_PIN 125 +#define RPM_SMD_LN_BB_A_CLK_PIN 126 #endif
The commit eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm clocks") defined the pin-controlled ln_bb_clk clocks, but didn't add them to the qcs404_clks array. Add them to make these clocks usable to platform devices. Fixes: eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm clocks") Reviewed-by: Alex Elder <elder@linaro.org? Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/clk/qcom/clk-smd-rpm.c | 2 ++ include/dt-bindings/clock/qcom,rpmcc.h | 2 ++ 2 files changed, 4 insertions(+)