| Message ID | 20221209215437.1783067-1-marijn.suijten@somainline.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3c3d2cb221b8647d1c547b4c44d2d6060cc742a9 |
| Headers | show |
| Series | arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv | expand |
On Freitag, 9. Dezember 2022 22:54:37 CET Marijn Suijten wrote: > This was pointed out in review but never followed up on thanks to > sidetracked discussions about labels vs node names. > > Fixes: 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 > peripheral") Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > arch/arm64/boot/dts/qcom/pmi8950.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi > b/arch/arm64/boot/dts/qcom/pmi8950.dtsi index 32d27e2187e3..8008f02434a9 > 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi > @@ -47,7 +47,7 @@ adc-chan@9 { > adc-chan@a { > reg = <VADC_REF_1250MV>; > qcom,pre-scaling = <1 1>; > - label = "ref_1250v"; > + label = "ref_1250mv"; Indeed 1250V are maybe a bit much ;) Thanks! Reviewed-by: Luca Weiss <luca@z3ntu.xyz> > }; > > adc-chan@d {
On 9.12.2022 22:54, Marijn Suijten wrote: > This was pointed out in review but never followed up on thanks to > sidetracked discussions about labels vs node names. > > Fixes: 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/pmi8950.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi > index 32d27e2187e3..8008f02434a9 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi > @@ -47,7 +47,7 @@ adc-chan@9 { > adc-chan@a { > reg = <VADC_REF_1250MV>; > qcom,pre-scaling = <1 1>; > - label = "ref_1250v"; > + label = "ref_1250mv"; > }; > > adc-chan@d {
On Fri, 9 Dec 2022 22:54:37 +0100, Marijn Suijten wrote: > This was pointed out in review but never followed up on thanks to > sidetracked discussions about labels vs node names. > > Applied, thanks! [1/1] arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv commit: 3c3d2cb221b8647d1c547b4c44d2d6060cc742a9 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi index 32d27e2187e3..8008f02434a9 100644 --- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi +++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi @@ -47,7 +47,7 @@ adc-chan@9 { adc-chan@a { reg = <VADC_REF_1250MV>; qcom,pre-scaling = <1 1>; - label = "ref_1250v"; + label = "ref_1250mv"; }; adc-chan@d {
This was pointed out in review but never followed up on thanks to sidetracked discussions about labels vs node names. Fixes: 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral") Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> --- arch/arm64/boot/dts/qcom/pmi8950.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)