| Message ID | 20221210113340.63833-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1629063ec9d8a32111a63ce7250a7781376c492a |
| Headers | show |
| Series | arm64: dts: qcom: sdm845: drop 0x from unit address | expand |
On 10.12.2022 12:33, Krzysztof Kozlowski wrote: > By coding style, unit address should not start with 0x. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- We somehow keep running into solving the same style issues :P https://lore.kernel.org/lkml/20220930191049.123256-8-konrad.dybcio@somainline.org/ Konrad > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 1a257f672887..a63dbd12230f 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -1636,7 +1636,7 @@ uart7: serial@89c000 { > }; > }; > > - gpi_dma1: dma-controller@0xa00000 { > + gpi_dma1: dma-controller@a00000 { > #dma-cells = <3>; > compatible = "qcom,sdm845-gpi-dma"; > reg = <0 0x00a00000 0 0x60000>;
On 10/12/2022 13:26, Konrad Dybcio wrote: > > > On 10.12.2022 12:33, Krzysztof Kozlowski wrote: >> By coding style, unit address should not start with 0x. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > We somehow keep running into solving the same style issues :P > > https://lore.kernel.org/lkml/20220930191049.123256-8-konrad.dybcio@somainline.org/ > Eh, this should have been just applied long time ago... Best regards, Krzysztof
On Sun, Dec 11, 2022 at 09:15:36PM +0100, Krzysztof Kozlowski wrote: > On 10/12/2022 13:26, Konrad Dybcio wrote: > > > > > > On 10.12.2022 12:33, Krzysztof Kozlowski wrote: > >> By coding style, unit address should not start with 0x. > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > > We somehow keep running into solving the same style issues :P > > > > https://lore.kernel.org/lkml/20220930191049.123256-8-konrad.dybcio@somainline.org/ > > > > Eh, this should have been just applied long time ago... > That's patch 7 in a series, which I would be expecting to see respun per your request for changes. @Konrad, please put fixes like that first in your series - or just send them separate from the series. Regards, Bjorn
On Sat, 10 Dec 2022 12:33:40 +0100, Krzysztof Kozlowski wrote: > By coding style, unit address should not start with 0x. > > Applied, thanks! [1/1] arm64: dts: qcom: sdm845: drop 0x from unit address commit: 1629063ec9d8a32111a63ce7250a7781376c492a Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 1a257f672887..a63dbd12230f 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -1636,7 +1636,7 @@ uart7: serial@89c000 { }; }; - gpi_dma1: dma-controller@0xa00000 { + gpi_dma1: dma-controller@a00000 { #dma-cells = <3>; compatible = "qcom,sdm845-gpi-dma"; reg = <0 0x00a00000 0 0x60000>;
By coding style, unit address should not start with 0x. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)