| Message ID | 20221213183305.544644-6-konrad.dybcio@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2,1/6] dt-bindings: i2c: qcom,i2c-cci: Fall back to common compatibles | expand |
On 13/12/2022 19:33, Konrad Dybcio wrote: > Many compatibles have been introduced, pointing to the same config data. > Leave a note reminding future developers to not do that again. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Changes in v2: > - new patch > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Dec 13, 2022 at 07:33:05PM +0100, Konrad Dybcio wrote: > Many compatibles have been introduced, pointing to the same config data. > Leave a note reminding future developers to not do that again. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c index a4b97fe3c3a5..01358472680c 100644 --- a/drivers/i2c/busses/i2c-qcom-cci.c +++ b/drivers/i2c/busses/i2c-qcom-cci.c @@ -811,9 +811,15 @@ static const struct cci_data cci_v2_data = { static const struct of_device_id cci_dt_match[] = { { .compatible = "qcom,msm8226-cci", .data = &cci_v1_data}, - { .compatible = "qcom,msm8916-cci", .data = &cci_v1_data}, { .compatible = "qcom,msm8974-cci", .data = &cci_v1_5_data}, { .compatible = "qcom,msm8996-cci", .data = &cci_v2_data}, + + + /* + * Legacy compatibles kept for backwards compatibility. + * Do not add any new ones unless they introduce a new config + */ + { .compatible = "qcom,msm8916-cci", .data = &cci_v1_data}, { .compatible = "qcom,sdm845-cci", .data = &cci_v2_data}, { .compatible = "qcom,sm8250-cci", .data = &cci_v2_data}, { .compatible = "qcom,sm8450-cci", .data = &cci_v2_data},
Many compatibles have been introduced, pointing to the same config data. Leave a note reminding future developers to not do that again. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Changes in v2: - new patch drivers/i2c/busses/i2c-qcom-cci.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)