| Message ID | 20221221071734.2887901-1-judyhsiao@chromium.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: sc7280: add display port audio | expand |
On 21/12/2022 08:17, Judy Hsiao wrote: > Add DisplayPort sound node and lpass_cpu node > in sc7280-herobrine-audio-rt5682.dtsi. > > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> > > -- > --- That's not a correct patch format. Apply it, git show and you will see the error. > > .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > index af685bc35e10..69e7aa7b2f6c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > @@ -33,9 +33,22 @@ codec { > }; > > dai-link@1 { > - link-name = "ALC5682"; > + link-name = "DisplayPort"; Why do you change link@1 from DP to ALC? Best regards, Krzysztof
> Why do you change link@1 from DP to ALC? Because I want make the order to be consistent with the 3 mic version. Thanks! https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi > > Best regards, > Krzysztof >
On 13/01/2023 02:24, Judy Hsiao wrote: >> Why do you change link@1 from DP to ALC? > Because I want make the order to be consistent with the 3 mic version. Thanks! > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi You cut entire context. I don't know what is this about. Best regards, Krzysztof
On 13/01/2023 03:24, Judy Hsiao wrote: >> Why do you change link@1 from DP to ALC? > Because I want make the order to be consistent with the 3 mic version. Thanks! > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi This should be explained in the commit message. And as Krzysztof wrote, it should be explained, rather than mentioning some other platform. >> >> Best regards, >> Krzysztof >>
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi index af685bc35e10..69e7aa7b2f6c 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi @@ -33,9 +33,22 @@ codec { }; dai-link@1 { - link-name = "ALC5682"; + link-name = "DisplayPort"; reg = <1>; + cpu { + sound-dai = <&lpass_cpu LPASS_DP_RX>; + }; + + codec { + sound-dai = <&mdss_dp>; + }; + }; + + dai-link@2 { + link-name = "ALC5682"; + reg = <2>; + cpu { sound-dai = <&lpass_cpu MI2S_PRIMARY>; }; @@ -92,6 +105,10 @@ dai-link@1 { reg = <MI2S_SECONDARY>; qcom,playback-sd-lines = <0>; }; + + dai-link@5 { + reg = <LPASS_DP_RX>; + }; }; /* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
Add DisplayPort sound node and lpass_cpu node in sc7280-herobrine-audio-rt5682.dtsi. Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> -- --- .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)